Date: Tue, 22 Aug 2023 23:07:32 +0200 From: Kristof Provost <kp@FreeBSD.org> To: Warner Losh <imp@FreeBSD.org>, Sumit Saxena <sumit.saxena@broadcom.com> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 91fcacc35597 - main - if_bnxt: Add support for VLAN on Thor Message-ID: <05979953-C089-4D56-99E3-BBBF066FE277@FreeBSD.org> In-Reply-To: <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org> References: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org> <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=_MailMate_FC533F11-A875-4AC6-843D-E98CF46C9FF7_= Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 27 Jun 2023, at 11:17, Kristof Provost wrote: > On 4 Nov 2022, at 23:55, Warner Losh wrote: >> The branch main has been updated by imp: >> >> URL: = >> https://cgit.FreeBSD.org/src/commit/?id=3D91fcacc355971f74aa26fc786102= 0dc3a2a2d717 >> >> commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 >> Author: Sumit Saxena <sumit.saxena@broadcom.com> >> AuthorDate: 2022-11-04 22:24:32 +0000 >> Commit: Warner Losh <imp@FreeBSD.org> >> CommitDate: 2022-11-04 22:24:32 +0000 >> >> if_bnxt: Add support for VLAN on Thor >> >> Reviewed by: imp >> Differential Revision: https://reviews.freebsd.org/D36443 >> --- >> sys/dev/bnxt/bnxt.h | 3 +- >> sys/dev/bnxt/bnxt_hwrm.c | 110 = >> ++++++++++++++++++++++++++++------------------- >> sys/dev/bnxt/bnxt_hwrm.h | 7 ++- >> sys/dev/bnxt/if_bnxt.c | 7 ++- >> 4 files changed, 74 insertions(+), 53 deletions(-) >> > > This commit appears to have broken vlan on these interfaces. > My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in = > a Dell T640, if that helps). > > A simple vlan creation on top of one: > ifconfig vlan create > ifconfig vlan0 vlan 201 vlandev bnxt0 > > Results in a loss of connectivity. The kernel logs this, which I = > assume is related: > > `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS = > error.` > > > After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) I = > can create vlan interfaces on top of bnxt0 without losing = > connectivity. > Should we revert this before 14.0? There=E2=80=99s also a report of what I think is the same issue in = [https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269133](https://bugs= =2Efreebsd.org/bugzilla/show_bug.cgi?id=3D269133) There=E2=80=99s a proposed patch there, but it did not work for me. Best regards, Kristof --=_MailMate_FC533F11-A875-4AC6-843D-E98CF46C9FF7_= Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html> <html> <head> <meta http-equiv=3D"Content-Type" content=3D"text/xhtml; charset=3Dutf-8"= > </head> <body><div style=3D"font-family: sans-serif;"><div class=3D"markdown" sty= le=3D"white-space: normal;"> <p dir=3D"auto">On 27 Jun 2023, at 11:17, Kristof Provost wrote:</p> </div><div class=3D"plaintext" style=3D"white-space: normal;"><blockquote= style=3D"margin: 0 0 5px; padding-left: 5px; border-left: 2px solid #136= BCE; color: #136BCE;"><p dir=3D"auto">On 4 Nov 2022, at 23:55, Warner Los= h wrote:</p> <blockquote style=3D"margin: 0 0 5px; padding-left: 5px; border-left: 2px= solid #136BCE; border-left-color: #4B89CF; color: #4B89CF;"><p dir=3D"au= to">The branch main has been updated by imp:</p> <p dir=3D"auto">URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D= 91fcacc355971f74aa26fc7861020dc3a2a2d717">https://cgit.FreeBSD.org/src/co= mmit/?id=3D91fcacc355971f74aa26fc7861020dc3a2a2d717</a></p> <p dir=3D"auto">commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 <br> Author: Sumit Saxena <sumit.saxena@broadcom.com> <br> AuthorDate: 2022-11-04 22:24:32 +0000 <br> Commit: Warner Losh <imp@FreeBSD.org> <br> CommitDate: 2022-11-04 22:24:32 +0000</p> <p dir=3D"auto"> if_bnxt: Add support for VLAN on Thor</p> <p dir=3D"auto"> Reviewed by: imp <br> Differential Revision: <a href=3D"https://reviews.freebsd.org/D36443"= >https://reviews.freebsd.org/D36443</a>; <br> --- <br> sys/dev/bnxt/bnxt.h | 3 +- <br> sys/dev/bnxt/bnxt_hwrm.c | 110 ++++++++++++++++++++++++++++-------------= ------ <br> sys/dev/bnxt/bnxt_hwrm.h | 7 ++- <br> sys/dev/bnxt/if_bnxt.c | 7 ++- <br> 4 files changed, 74 insertions(+), 53 deletions(-)</p> </blockquote><p dir=3D"auto">This commit appears to have broken vlan on t= hese interfaces. <br> My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in a = Dell T640, if that helps).</p> <p dir=3D"auto">A simple vlan creation on top of one: <br> ifconfig vlan create <br> ifconfig vlan0 vlan 201 vlandev bnxt0</p> <p dir=3D"auto">Results in a loss of connectivity. The kernel logs this, = which I assume is related:</p> <p dir=3D"auto">`bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID= _PARAMS error.`</p> <p dir=3D"auto">After reverting this (and 72e9dbb58cad5262190cf2eae47f764= 021072128) I can create vlan interfaces on top of bnxt0 without losing co= nnectivity.</p> <br></blockquote></div> <div class=3D"markdown" style=3D"white-space: normal;"> <p dir=3D"auto">Should we revert this before 14.0?</p> <p dir=3D"auto">There=E2=80=99s also a report of what I think is the same= issue in <a href=3D"https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D= 269133">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269133</a></p= > <p dir=3D"auto">There=E2=80=99s a proposed patch there, but it did not wo= rk for me.</p> <p dir=3D"auto">Best regards,<br> Kristof</p> </div> </div> </body> </html> --=_MailMate_FC533F11-A875-4AC6-843D-E98CF46C9FF7_=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?05979953-C089-4D56-99E3-BBBF066FE277>