Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Sep 2019 21:10:35 +0200
From:      =?utf-8?Q?Pawe=C5=82_Biernacki?= <kaktus@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r352914 - head/sys/compat/linux
Message-ID:  <30C3B920-8F83-4677-A984-4701A505D4AC@FreeBSD.org>
In-Reply-To: <201909301905.x8UJ5EB0029624@repo.freebsd.org>
References:  <201909301905.x8UJ5EB0029624@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help


> On 30 Sep 2019, at 21:05, Pawel Biernacki <kaktus@FreeBSD.org> wrote:
>=20
> Author: kaktus
> Date: Mon Sep 30 19:05:14 2019
> New Revision: 352914
> URL: https://svnweb.freebsd.org/changeset/base/352914
>=20
> Log:
>  linux_renameat2: don't add extra \n on error.
>=20
>  linux_msg() already adds \n at the end of all messages.
>=20
>  Reported by:	emaste, kib (mentor), mjg (mentor)
>  Reviewed by:	kib (mentor), mjg (mentor)

Should be:
Reviewed by:	emaste, kib (mentor), mjg (mentor)
Approved by:	kib (mentor), mjg (mentor)


>  Differential Revision:	https://reviews.freebsd.org/D21852
>=20
> Modified:
>  head/sys/compat/linux/linux_file.c
>=20
> Modified: head/sys/compat/linux/linux_file.c
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
> --- head/sys/compat/linux/linux_file.c	Mon Sep 30 19:03:43 2019	=
(r352913)
> +++ head/sys/compat/linux/linux_file.c	Mon Sep 30 19:05:14 2019	=
(r352914)
> @@ -704,7 +704,7 @@ linux_renameat2(struct thread *td, struct =
linux_rename
> 	int error, olddfd, newdfd;
>=20
> 	if (args->flags !=3D 0) {
> -		linux_msg(td, "renameat2 unsupported flags 0x%x\n",
> +		linux_msg(td, "renameat2 unsupported flags 0x%x",
> 		    args->flags);
> 		return (EINVAL);
> 	}




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?30C3B920-8F83-4677-A984-4701A505D4AC>