Date: Sat, 10 Dec 2011 17:40:08 GMT From: Jaakko Heinonen <jh@FreeBSD.org> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs and procfs. Message-ID: <201112101740.pBAHe8wP063920@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/163076; it has been noted by GNATS. From: Jaakko Heinonen <jh@FreeBSD.org> To: Dag-Erling =?utf-8?B?U23DuHJncmF2?= <des@des.no> Cc: Poul-Henning Kamp <phk@phk.freebsd.dk>, Petr Salinger <Petr.Salinger@seznam.cz>, bug-followup@FreeBSD.org, mdf@FreeBSD.org Subject: Re: kern/163076: It is not possible to read in chunks from linprocfs and procfs. Date: Sat, 10 Dec 2011 19:35:43 +0200 On 2011-12-10, Dag-Erling Smørgrav wrote: > Jaakko Heinonen <jh@FreeBSD.org> writes: > > Could you give an example about such state? Isn't the length first > > initialized to zero and then increased only when byte(s) has been > > successfully appended to the buffer? sbuf_len() has worked for > > unfinished buffers since r71724. > > A fixed-length sbuf may overflow intentionally (as in pseudofs) or > unintentionally; a dynamic sbuf may also overflow due to a memory > allocation failure. The first two cases are expected, but the third is > not, and I am not sure the sbuf should be considered valid in such a > case. Thanks, I see your point. However, currently after a memory allocation failure, finishing the buffer is allowed and sbuf_data() will return the buffer. According to phk@ sbuf_finish() should finish any buffer. -- Jaakko
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112101740.pBAHe8wP063920>