Date: Mon, 21 Jul 2014 22:57:03 +0200 From: Antoine Brodin <antoine@FreeBSD.org> To: Adam Weinberger <adamw@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r362484 - head/www/WebMagick Message-ID: <CAALwa8=Pi14WpoGLjg53-9a64q2Xa=tZopc=xBDi%2B-wrnBYOiA@mail.gmail.com> In-Reply-To: <201407212053.s6LKru8U037225@svn.freebsd.org> References: <201407212053.s6LKru8U037225@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 21, 2014 at 10:53 PM, Adam Weinberger <adamw@freebsd.org> wrote: > Author: adamw > Date: Mon Jul 21 20:53:56 2014 > New Revision: 362484 > URL: http://svnweb.freebsd.org/changeset/ports/362484 > QAT: https://qat.redports.org/buildarchive/r362484/ > > Log: > As suggested by ache, actually check for the presence of Image/Magick.pm and only barf if it > doesn't exist. > > Modified: > head/www/WebMagick/Makefile > > Modified: head/www/WebMagick/Makefile > ============================================================================== > --- head/www/WebMagick/Makefile Mon Jul 21 20:51:34 2014 (r362483) > +++ head/www/WebMagick/Makefile Mon Jul 21 20:53:56 2014 (r362484) > @@ -38,12 +38,15 @@ X11_BUILD_DEPENDS= xlsfonts:${PORTSDIR}/ > X11_RUN_DEPENDS= xlsfonts:${PORTSDIR}/x11-fonts/xlsfonts > X11_CONFIGURE_ENV_OFF= with_x=no > > -pre-everything:: > - @${ECHO_CMD} > - @${ECHO_CMD} ${PORTNAME} requires that ImageMagick be installed with the PERL option enabled. > - @${ECHO_CMD} > +.include <bsd.port.pre.mk> > + > +do-configure: > + @if [ ! -f ${SITE_PERL}/${PERL_ARCH}/Image/Magick.pm ]; then \ > + ${ECHO_CMD} ERROR: ImageMagick must be installed with the PERL option enabled; \ > + ${FALSE}; \ > + fi > > pre-install: > @${MKDIR} ${STAGEDIR}${PREFIX}/www/data > > -.include <bsd.port.mk> > +.include <bsd.port.post.mk> > Hi, A custom do-configure looks really wrong.. Cheers, Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8=Pi14WpoGLjg53-9a64q2Xa=tZopc=xBDi%2B-wrnBYOiA>