Date: Wed, 26 Apr 2017 16:22:25 +0000 From: rgrimes <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] D10485: Replace dhcp option 150 by 66 Message-ID: <4ae187764681a2fa6897797f25c1165a@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-rdfe23ryefhflnjblbcr-req@FreeBSD.org> References: <differential-rev-PHID-DREV-rdfe23ryefhflnjblbcr-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
rgrimes added inline comments.
INLINE COMMENTS
> bootp.c:443
> + if (tag == TAG_TFTP_SERVER_NAME) {
> + val = strsep(&cp, VEND_INFO_END);
> + if ((ipaddr = inet_addr(val)) != INADDR_NONE)
You marked this as done but it still only accepts a dotted quad, if we cant process a hostname here maybe that is why Bapt used option 150? As a minimum add a comment saying there is a known bug here with not processing a hostname, maybe /* XXX Should accept hostname as well as dotted quad */
> bootp.h:99
> +
> +#define VEND_INFO_END 0xff /* End option in RFC2132 */
>
Good catch, this also makes it match all the options before it in style of value with the cast.
REVISION DETAIL
https://reviews.freebsd.org/D10485
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: kczekirda, bapt, oshogbo, tsoome, sbruno, #network, freebsd-net-list, imp
Cc: rgrimes, garga, ler, asomers
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4ae187764681a2fa6897797f25c1165a>