Date: Fri, 24 Oct 2008 18:07:41 +0200 From: "Attilio Rao" <attilio@freebsd.org> To: "=?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?=" <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Jung-uk Kim <jkim@freebsd.org> Subject: Re: svn commit: r184108 - head/sys/i386/i386 Message-ID: <3bbf2fe10810240907w2e05b0a7see5fe8ba49494c0a@mail.gmail.com> In-Reply-To: <86bpxb34mz.fsf@ds4.des.no> References: <200810210431.m9L4V7Pb088978@svn.freebsd.org> <3bbf2fe10810210307t664cc8a2s62606f03427286f3@mail.gmail.com> <200810211605.46927.jkim@FreeBSD.org> <3bbf2fe10810220853r34256b59y1fe57f49eca2014@mail.gmail.com> <86bpxb34mz.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
2008/10/23 Dag-Erling Smørgrav <des@des.no>: > "Attilio Rao" <attilio@freebsd.org> writes: >> I think it is silly we have different quirks flag states for TSC. We >> should just having a table assuming that the TSC is safe to use in SMP >> environments and gets rid of any other flag (in this case, for amd64 >> based machine, the logic could, for example, check if the CPU is P >> state invariant and assume it is safe, etc.) > > No, these are two entirely different things. An SMP-safe TSC is a TSC > that is synchronized across cores / packages. A P-state invariant TSC > is a TSC that does not vary with the CPU frequency. One does not imply > the other, and in many cases (if not most), there is no way to detect > programmatically that the TSC is SMP-safe or P-state invariant or both. But I'm not saying they are the same at all. What I'm saying is that we should just have a whitelist of allowed architectures with valid TSC (not affected by any problem) and allow TSC as default timecounter for that. If we, additively, wants to export informations about the TSC (is it Pstate invariant? is it smp invariant in freq for smp? etc) we can do with a bitfield. In order to determine if a TSC works or not we could start with a testing suite, involving ACPI states changing and test TSC variations. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3bbf2fe10810240907w2e05b0a7see5fe8ba49494c0a>