Date: Tue, 17 Sep 2002 09:28:35 -0700 From: Peter Wemm <peter@wemm.org> To: Daniel Eischen <eischen@pcnet1.pcnet.com> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc/gen swapcontext.c Message-ID: <20020917162835.D8BD02A7D6@canning.wemm.org> In-Reply-To: <Pine.GSO.4.10.10209170924290.4728-100000@pcnet1.pcnet.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Daniel Eischen wrote:
> On Mon, 16 Sep 2002, Peter Wemm wrote:
>
> > peter 2002/09/16 23:22:52 PDT
> >
> > Modified files:
> > lib/libc/gen swapcontext.c
> > Log:
> > Bandaid to stop failing on non-i386 platforms.
> > Add a big ugly #warning as a reminder.
>
> Is there a problem with dependencies? mc_len is a member
> of mcontext_t in sys/${ARCH}/include/ucontext.h.
There are several problems with the recent commits:
1: mc_len only exists for i386, this breaks the alpha builds.
2: only sys/i386/include/ucontext.h exists
3: get_mcontext() and set_mcontext() are prototyped only in
sys/i386/include/ucontext.h, yet is used in a MI file (kern_thread.c),
so kernel compiles of kern_thread.c fail due to missing prototypes.
4: Is the prototype expected to be different on some platforms? If not, then
it should not be in a MD include file, it should be in an MI include file
or it will become another thing to get out of sync.
5: get_mcontext() and set_mcontext() only exist on i386, yet it is called
from MI code on all platforms, so kernel links fail due to missing
functions.
Cheers,
-Peter
--
Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com
"All of this is for nothing if we don't go to the stars" - JMS/B5
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020917162835.D8BD02A7D6>