Date: Fri, 19 Oct 2007 19:18:08 +0200 From: Max Laier <max@love2party.net> To: Robert Watson <rwatson@freebsd.org> Cc: Darren Reed <darrenr@freebsd.org>, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/contrib/ipfilter/netinet - Imported sources Message-ID: <200710191918.25235.max@love2party.net> In-Reply-To: <20071019175247.C83542@fledge.watson.org> References: <200710182142.l9ILgsGd015588@repoman.freebsd.org> <20071019175247.C83542@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart6125884.gSIXVcmuoo Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Friday 19 October 2007, Robert Watson wrote: > On Thu, 18 Oct 2007, Darren Reed wrote: > > darrenr 2007-10-18 21:42:54 UTC > > > > FreeBSD src repository > > > > src/sys/contrib/ipfilter/netinet - Imported sources > > Update of /home/ncvs/src/sys/contrib/ipfilter/netinet > > In directory repoman.freebsd.org:/tmp/cvs-serv15525 > > > > Log Message: > > Import IPFilter 4.1.28 > > > > Status: > > > > Vendor Tag: DARRENR > > Release Tags: v4-1-28 > > I didn't see a reply from you on the thread on current@ regarding the > ipfilter panics, so I'll ask here: does this import resolve the panics > that users are experiencing with ipfilter on 7.x/8.x when INVARIANTS is > enabled? According to my reading, the crashes described in=20 http://lists.freebsd.org/pipermail/freebsd-current/2007-October/078484.html= =20 are still present due to the following code in ip_fil_freebsd.c line=20 490ff: READ_ENTER(&ipf_global); error =3D fr_ioctlswitch(unit, data, cmd, mode, p->p_uid, p); Where fr_ioctlswitch() does the actual copyin/copyout and READ_ENTER=20 acquires a rwlock(9) which can't sleep. This is an improvement over the=20 previous attempt to sleep in the transmission path (due to useing sx(9)=20 locks), but it is still not correct and fragile even without INVARIANTS. =2D-=20 /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News --nextPart6125884.gSIXVcmuoo Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQBHGObhXyyEoT62BG0RAl46AJ9UhNkiUA8jFnyDEhK6t/fA57vBIQCfZKnF 40qKlVxtWo6TxMO719MS30Y= =LOWw -----END PGP SIGNATURE----- --nextPart6125884.gSIXVcmuoo--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200710191918.25235.max>