Date: Mon, 13 May 2002 09:38:38 -0700 (PDT) From: Matthew Dillon <dillon@apollo.backplane.com> To: Bruce Campbell <bruce@engmail.uwaterloo.ca> Cc: Danny Schales <dan@coes.LaTech.edu>, Rolandas Naujikas <rolnas@takas.lt>, Doug White <dwhite@resnet.uoregon.edu>, Wilko Bulte <wkb@freebie.xs4all.nl>, Paul Horechuk <phorechuk@docucom.ca>, stable@FreeBSD.ORG Subject: Re: nfs_fsync: not dirty error in 4.5-RELEASE (possible solution) Message-ID: <200205131638.g4DGcc72068498@apollo.backplane.com> References: <Pine.GSO.4.05.10205130845380.4982-100000@engmail.uwaterloo.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
Excellent! Thanks for the confirmation, Bruce. I comitted this
patch on April 3rd after getting positive results from Danny, but it's
always nice to have independant confirmation that a bugs been fixed!
-Matt
Matthew Dillon
<dillon@backplane.com>
:I've been running the patch below now for almost a month on 3 separate
:systems, with no problems now.
:
:These 3 systems had previously experienced about 10 "nfs_fsync: not dirty"
:panics since they had been installed just 3 weeks prior.
:
:My analysis of 10 panics in 3 weeks versus 0 panics in 4 weeks makes
:me suspect the problem has been fixed with the patch below.
:
:...
:> I believe that the correct fix is to change this code to:
:>
:> /*
:> * If B_INVAL, clear B_DELWRI. We've already placed the buffer
:> * on the correct queue.
:> */
:> if ((bp->b_flags & (B_INVAL|B_DELWRI)) == (B_INVAL|B_DELWRI))
:> bundirty(bp);
:>
:> -Matt
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205131638.g4DGcc72068498>