Date: Sat, 12 May 2007 09:12:39 +0200 From: Stefan Farfeleder <stefan@fafoe.narf.at> To: Yuriy Tsibizov <Yuriy.Tsibizov@gfk.ru> Cc: freebsd-current@freebsd.org Subject: Re: geom_label problems when MS-DOS FS label is blank (all spaces) Message-ID: <20070512071231.GB944@lizard.fafoe.narf.at> In-Reply-To: <20070512104053.J943@free.home.local> References: <20070509125720.U911@free.home.local> <20070512104053.J943@free.home.local>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 12, 2007 at 10:51:25AM +0400, Yuriy Tsibizov wrote:
> > In this situation libdisk can't parse kern.geom.conftxt and sysinstall
> > exits with BARF 171 message.
>
> It can be fixed with following patch. "all spaces" volume will be treated
> like a volume without label.
>
> Index: g_label_msdosfs.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/geom/label/g_label_msdosfs.c,v
> retrieving revision 1.6
> diff -u -r1.6 g_label_msdosfs.c
> --- g_label_msdosfs.c 30 Sep 2006 08:16:49 -0000 1.6
> +++ g_label_msdosfs.c 12 May 2007 06:39:23 -0000
> @@ -200,7 +200,7 @@
> }
>
> endofchecks:
> - for (i = size - 1; i > 0; i--) {
> + for (i = size - 1; i >= 0; i--) {
> if (label[i] == '\0')
> continue;
> else if (label[i] == ' ')
This won't work because i is unsigned.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070512071231.GB944>