Date: Sun, 06 Jun 2004 13:07:05 -0400 From: Joe Marcus Clarke <marcus@FreeBSD.org> To: Oliver Eikemeier <eikemeier@fillmore-labs.com> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/portlint Makefile ports/devel/portlint/src portlint.pl Message-ID: <1086541625.34425.1.camel@shumai.marcuscom.com> In-Reply-To: <40C2CE39.5030402@fillmore-labs.com> References: <200406060106.i5616XNX076254@repoman.freebsd.org> <40C2CE39.5030402@fillmore-labs.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sun, 2004-06-06 at 03:56, Oliver Eikemeier wrote: > Joe Marcus Clarke wrote: > > > * Check distinfo to make sure each file in DISTFILES has SIZE and MD5 entries > > if NO_SIZE and NO_CHECKSUM are not defined > > I believe this change serves no useful purpose and should be undone: > > - no rule mandates the use of SIZE in distfiles. `make makesum' adds it by default, > so if it is missing it is removed on purpose, e.g. to account for an mirror that > has an broken http server. > > - the patch does not check PATCHFILES > > - the check fails for DISTFILES that use :group notation > > - bsd.port.mk already checks whether distinfo is consitent in terms of existing MD5 > lines, no point in repeating this check in portlint > > - the patch mandates SIZE lines for distfiles which are added to IGNOREFILES and have > MD5 (...) = IGNORE, which makes no sense. > > Generally patches like this should be checked with portlintgrep to see what ports > they flag, and whether they solve an existing or potential problem in the ports tree. This was supposed to solve a problem that I've personally hit a few times. It was just another check to make sure PKGNAME agrees with what is in distinfo. At one time, I was thinking about PATCHFILES and the :group stuff, but I rushed 2.6.3 out for the sake of the deprecated macros. In the meantime, I've reverted the changes until I can make them work for the majority of cases. Joe > > -Oliver -- Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAw085b2iPiv4Uz4cRAm62AJ4yE11cpyLUI+oHEjs+OYNQgZYhdwCffoGn /mNPoiIksMovcp/Wq351nwg= =bsrx -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1086541625.34425.1.camel>