Date: Wed, 18 Jan 2012 05:57:16 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: eadler@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r228790 - in head/usr.sbin: fwcontrol newsyslog ypserv Message-ID: <20120118.055716.647522865702856321.hrs@allbsd.org> In-Reply-To: <201112212027.pBLKRfPK084637@svn.freebsd.org> References: <201112212027.pBLKRfPK084637@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Wed_Jan_18_05_57_16_2012_764)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Eitan Adler <eadler@FreeBSD.org> wrote in <201112212027.pBLKRfPK084637@svn.freebsd.org>: ea> Author: eadler (ports committer) ea> Date: Wed Dec 21 20:27:41 2011 ea> New Revision: 228790 ea> URL: http://svn.freebsd.org/changeset/base/228790 ea> ea> Log: ea> - Remove extraneous null ptr deref checks ea> - Fix memory leak ea> ea> Submitted by: Slono Slono <slonoman2011@yandex.ru> ea> Approved by: jhb ea> MFC after: 1 week ea> ea> Modified: ea> head/usr.sbin/fwcontrol/fwcontrol.c ea> head/usr.sbin/newsyslog/newsyslog.c ea> head/usr.sbin/ypserv/yp_main.c I suspects you did not test ypserv after this change. Freeing the pointer sname at the end of create_service() is completely wrong and probably people get the following error message when invoking ypserv: getaddrinfo(): servname not supported for ai_socktype -- Hiroki ----Security_Multipart(Wed_Jan_18_05_57_16_2012_764)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk8V4KwACgkQTyzT2CeTzy1vzgCfWz67OCry7fRH5m9rJzqAXcog Q18AnRy17FU/oYpEtgjcSW4M8281e81i =cFSe -----END PGP SIGNATURE----- ----Security_Multipart(Wed_Jan_18_05_57_16_2012_764)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120118.055716.647522865702856321.hrs>