Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 25 Jul 2002 19:21:09 +0300
From:      Ruslan Ermilov <ru@FreeBSD.org>
To:        John Hay <jhay@icomtek.csir.co.za>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src Makefile Makefile.inc1 src/secure Makefile src/share/man/man7 release.7 src/kerberos5 Makefile Makefile.inc
Message-ID:  <20020725162109.GA32393@sunbay.com>
In-Reply-To: <200207251417.g6PEHxC72514@zibbi.icomtek.csir.co.za>
References:  <200207251327.g6PDROE70536@zibbi.icomtek.csir.co.za> <200207251417.g6PEHxC72514@zibbi.icomtek.csir.co.za>

index | next in thread | previous in thread | raw e-mail

[-- Attachment #1 --]
On Thu, Jul 25, 2002 at 04:17:59PM +0200, John Hay wrote:
> [...]
> > > > > >     release              Makefile 
> [...]
> > > > > 
> > > > > This has been tested on an i386 box with TARGET_ARCH=i386,
> > > > > TARGET_ARCH=alpha, and TARGET=pc98.  Alpha died by ENOSPC
> > > > > attempting to create the mfsroot floppy later in release.9.
> > > > > I think this is reproduceable on Alphas too.
> > > > > 
> > > > > IMPORTANT.  For anyone attempting to "reproduce" this.  It
> > > > > is important that /usr/src/release/Makefile be the latest
> > > > > version (cd /usr/src/release; cvs up -l) before attempting
> > > > > to "make release".  I'm still looking for a clean way to
> > > > > overcome this (old) problem.
> > > > 
> > > > With this change I cannot build a release with docs on -stable
> > > > anymore. The culprit is again the interaction of TARGET_ARCH
> > > > and print/ghostscript-gnu, just as on -current.
> > > > 
> > > Even if TARGET_ARCH=${MACHINE_ARCH}?  Have you tried my work
> > > around?
> > 
> > With workaround do you mean that /usr/src/release/Makefile also
> > have to be up-to-date? If so, yes, I did update that to:
> > 
> > $FreeBSD: src/release/Makefile,v 1.536.2.88 2002/07/25 09:33:16 ru Exp $
> > 
> > I don't specifically set TARGET_ARCH, I just do a make release on a
> > i386 box to get an i386 release.
> 
> This patch work around the problem. It gets my box past building
> the doc tools at least.
> 
As I said, the real problem is probably with bsd.port.mk.

The problem is demonstrated like this:

$ touch foo.c
$ gmake -f /dev/null foo TARGET_ARCH=bar
cc    bar foo.c   -o foo
cc: bar: No such file or directory
gmake: *** [foo] Error 1
$

I can't find anywhere in the gmake(1) docs what the intent
of the TARGET_ARCH is.  I have similarly failed to find any
info on the topic on www.gnu.org.

But I think that the problem is more generic: somewhere,
someone should pass a clean environment (/usr/bin/env -i)
when running port's makefile(s).

> Index: release/Makefile
> ===================================================================
> RCS file: /home/ncvs/src/release/Makefile,v
> retrieving revision 1.536.2.88
> diff -u -r1.536.2.88 Makefile
> --- release/Makefile	25 Jul 2002 09:33:16 -0000	1.536.2.88
> +++ release/Makefile	25 Jul 2002 13:34:52 -0000
> @@ -830,6 +830,7 @@
>  doc.1:
>  	@echo "Making docs..."
>  	@for i in ${DOCPORTS}; do \
> +	  unset TARGET_ARCH; \
>  	  cd /usr/ports/$$i && make all install clean BATCH=yes JADETEX=no WITHOUT_PYTHON=yes FORCE_PKG_REGISTER=yes; \
>  	done
>  	@cd /usr/doc && make all install 'FORMATS=html html-split txt' INSTALL_COMPRESSED='' DOCDIR=${RD}/trees/bin/usr/share/doc

I would prefer the "cd /usr/ports/$$i && env -i make all ..." version,
if it works, FWIW.


Cheers,
-- 
Ruslan Ermilov		Sysadmin and DBA,
ru@sunbay.com		Sunbay Software AG,
ru@FreeBSD.org		FreeBSD committer,
+380.652.512.251	Simferopol, Ukraine

http://www.FreeBSD.org	The Power To Serve
http://www.oracle.com	Enabling The Information Age

[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iD8DBQE9QCV1Ukv4P6juNwoRAmqtAJ9uuJjMDaQrnx8oaFjuaFCM9AV7wgCfdFY+
ZlBETu1I2U+IDqW+AaTIAv0=
=lcRI
-----END PGP SIGNATURE-----
help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020725162109.GA32393>