Date: Sat, 18 Feb 2012 19:11:40 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Mark Linimon <linimon@lonesome.com> Cc: Michael Scheidell <michael.scheidell@secnap.com>, Andriy Gapon <avg@FreeBSD.org>, Steve Kargl <sgk@troutmask.apl.washington.edu>, Chris Rees <utisoft@gmail.com>, "freebsd-ports@FreeBSD.org" <freebsd-ports@FreeBSD.org> Subject: Re: Please test your commits Message-ID: <4F40686C.6030800@FreeBSD.org> In-Reply-To: <20120219030318.GB6927@lonesome.com> References: <d11bb0d2-36dd-4745-8661-733fccdb977b@blur> <ebd5ff06-8b41-4dc3-8bea-02972f22019d@blur> <20120217182214.GD11416@lonesome.com> <4F403B69.9030503@FreeBSD.org> <20120219030318.GB6927@lonesome.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 02/18/2012 19:03, Mark Linimon wrote:
> On Sat, Feb 18, 2012 at 03:59:37PM -0800, Doug Barton wrote:
>> Where I think reasonable minds can differ are (appropriate) responses of
>> the form, "This was not done properly, here is how it can/should be done
>> (better)." IMO those should *always* be public in order to help others
>> who are paying attention to the same topic.
>
> Fair enough. Perhaps I should have been more clear about the distinction
> I make between constructive criticism ("this code would be more effectively
> stated xyz") vs. non-constructive criticism ("your mother smells of
> elderberries".)
I thought it went without saying that those messages just shouldn't be
sent.
Doug (typed out maybe, but not sent)
--
It's always a long day; 86400 doesn't fit into a short.
Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F40686C.6030800>