Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 5 May 2019 06:38:47 +0000 (UTC)
From:      Toomas Soome <tsoome@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r347142 - head/stand/common
Message-ID:  <201905050638.x456clk7047111@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: tsoome
Date: Sun May  5 06:38:47 2019
New Revision: 347142
URL: https://svnweb.freebsd.org/changeset/base/347142

Log:
  loader: validate sectorsize argument in disk_open()
  
  The bug and patch is reported against 11.2, but it is good idea to have
  the check in place for all versions.
  
  PR:		236585
  Submitted by:	john@feith.com
  Reported by:	john@feith.com
  MFC after:	1 day

Modified:
  head/stand/common/disk.c

Modified: head/stand/common/disk.c
==============================================================================
--- head/stand/common/disk.c	Sun May  5 06:32:40 2019	(r347141)
+++ head/stand/common/disk.c	Sun May  5 06:38:47 2019	(r347142)
@@ -221,6 +221,10 @@ disk_open(struct disk_devdesc *dev, uint64_t mediasize
 	struct ptable_entry part;
 	int rc, slice, partition;
 
+	if (sectorsize == 0) {
+		DPRINTF("unknown sector size");
+		return (ENXIO);
+	}
 	rc = 0;
 	od = (struct open_disk *)malloc(sizeof(struct open_disk));
 	if (od == NULL) {



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905050638.x456clk7047111>