Date: Tue, 7 Nov 2006 23:32:40 +0100 (CET) From: Victor Balada Diaz <victor@bsdes.net> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/105262: MAINTAINER UPDATE: fix boot script on mail/milter-bogom Message-ID: <200611072232.kA7MWeQx065171@alf.dyndns.ws> Resent-Message-ID: <200611072240.kA7MeN7v023205@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 105262
>Category: ports
>Synopsis: MAINTAINER UPDATE: fix boot script on mail/milter-bogom
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: maintainer-update
>Submitter-Id: current-users
>Arrival-Date: Tue Nov 07 22:40:22 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Victor Balada Diaz
>Release: FreeBSD 5.3-RELEASE-p29 i386
>Organization:
>Environment:
not applicable
>Description:
the boot script evaluated milterbogom_flags before reading the configuration from
rc.conf, so if you changed things like milterbogom_user it will not take
the changes.
This was noticed by Andrey Chernov and he also sent the patch to fix it.
>How-To-Repeat:
>Fix:
--- milter-bogom.sh.in.patch begins here ---
Index: milter-bogom.sh.in
===================================================================
RCS file: /home/ncvs/ports/mail/milter-bogom/files/milter-bogom.sh.in,v
retrieving revision 1.1
diff -u -r1.1 milter-bogom.sh.in
--- milter-bogom.sh.in 25 May 2005 08:12:34 -0000 1.1
+++ milter-bogom.sh.in 7 Nov 2006 22:25:39 -0000
@@ -5,24 +5,24 @@
# BEFORE: sendmail
# KEYWORD: milterbogom
-milterbogom_enable=${milterbogom_enable-"NO"}
-milterbogom_socket=${milterbogom_socket-"unix:/var/run/bogom/milter.sock"}
-milterbogom_user=${milterbogom_user-"bogomilter"}
-milterbogom_pid=${milterbogom_pid-"/var/run/bogom/bogom.pid"}
-milterbogom_flags=${milterbogom_flags-"-u ${milterbogom_user} \
--s ${milterbogom_socket} -p ${milterbogom_pid}"}
-
-
. %%RC_SUBR%%
name=milterbogom
-pidfile=${milterbogom_pid}
rcvar=`set_rcvar`
command=%%PREFIX%%/sbin/bogom
start_precmd="bogom_precmd"
stop_postcmd="bogom_postcmd"
load_rc_config $name
+
+milterbogom_enable=${milterbogom_enable-"NO"}
+milterbogom_socket=${milterbogom_socket-"unix:/var/run/bogom/milter.sock"}
+milterbogom_user=${milterbogom_user-"bogomilter"}
+milterbogom_pid=${milterbogom_pid-"/var/run/bogom/bogom.pid"}
+milterbogom_flags=${milterbogom_flags-"-u ${milterbogom_user} \
+-s ${milterbogom_socket} -p ${milterbogom_pid}"}
+
+pidfile=${milterbogom_pid}
bogom_precmd()
{
--- milter-bogom.sh.in.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611072232.kA7MWeQx065171>