Date: Fri, 26 Aug 2022 17:51:07 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Jung-uk Kim <jkim@freebsd.org> Cc: FreeBSD CURRENT <freebsd-current@freebsd.org> Subject: Re: Lenovo Legion 5 Intel speakers working ok! Message-ID: <CAFDf7ULdWYorTr0CZL=oDB6PyVVB5bEgcpCxLi4o=%2Bfjqd2Arw@mail.gmail.com> In-Reply-To: <385387e0-9dae-d797-1af0-05cd44b4300c@FreeBSD.org> References: <CAFDf7U%2BbEh6X8r3JPS=5dRbSZ8CJgF74kCM4uGEKVo6QZ9Ex2Q@mail.gmail.com> <CAFDf7UKSaMHMZCtsydS4no6YREYXa76Z4G3ZSZtxDLGga7iOng@mail.gmail.com> <94e271b7-3019-a377-bb8b-e681c78b0d82@FreeBSD.org> <CAFDf7U%2BDdFu14TupbSB5xu1JN=NhEJqF5M_h%2ByU2VKfkyzfxAQ@mail.gmail.com> <385387e0-9dae-d797-1af0-05cd44b4300c@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000001acb2e05e727b9d9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi all! patch ready and tested at PR 265632 <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265632>; Cheers, Jung-uk Kim <jkim@freebsd.org> escreveu no dia quinta, 25/08/2022 =C3=A0(s) 21:24: > On 22. 8. 25., Nuno Teixeira wrote: > > Hi! > > > > `pciconf -l | grep ^hdac`: > > --- > > hdac1@pci0:0:31:3: class=3D0x040380 rev=3D0x00 hdr=3D0x00 vendor= =3D0x8086 > > device=3D0x06c8 subvendor=3D0x17aa subdevice=3D0x380f > > ^^^^ > > > > ^^^^^ ^^^^ > > hdac0@pci0:1:0:1: class=3D0x040300 rev=3D0xa1 hdr=3D0x00 vendor= =3D0x10de > > device=3D0x10fa subvendor=3D0x17aa subdevice=3D0x3ffb > > --- > > > > I think hdac1 is what I'm looking for: > > --- > > hdac1@pci0:0:31:3: class=3D0x040380 rev=3D0x00 hdr=3D0x00 vendor= =3D0x8086 > > device=3D0x06c8 subvendor=3D0x17aa subdevice=3D0x380f > > vendor =3D 'Intel Corporation' > > device =3D 'Comet Lake PCH cAVS' > > class =3D multimedia > > subclass =3D HDA > > --- > > > > (LENOVO_VENDORID 0x17aa) > > > > maybe: > > #define LENOVO_L5INTEL_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x380f) ? > > > > ^^^^ > > > ^^^^ > > I guess. :-) > > JK > > > Jung-uk Kim <jkim@freebsd.org <mailto:jkim@freebsd.org>> escreveu no > dia > > quinta, 25/08/2022 =C3=A0(s) 20:15: > > > > On 22. 8. 25., Nuno Teixeira wrote: > > > ** Same config were imported from D30333 > > > <https://reviews.freebsd.org/D30333 > > <https://reviews.freebsd.org/D30333>>for Legion 5 AMD, PR 265632 > > > <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265632 > > <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265632>>for In= tel > > version > > > > > > Nuno Teixeira <eduardo@freebsd.org <mailto:eduardo@freebsd.org> > > <mailto:eduardo@freebsd.org <mailto:eduardo@freebsd.org>>> > > > escreveu no dia quinta, 25/08/2022 =C3=A0(s) 19:59: > > > > > > Hello, > > > > > > I have Lenovo Legion 5 Intel speakers working ok with > > device.hints: > > > --- > > > hint.hdaa.1.nid20.config=3D"as=3D1 seq=3D0" > > > hint.hdaa.1.nid33.config=3D"as=3D1 seq=3D15" > > > --- > > > > > > Same config were imported from D30333 > > > <https://reviews.freebsd.org/D30333 > > <https://reviews.freebsd.org/D30333>>and PR 265632 > > > <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265632 > > <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265632>>; for > > > Legion 5 AMD: > > > (sys/dev/sound/pci/hda/hdac.h) > > > --- > > > #define LENOVO_L5AMD_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, > > 0x381b) > > > --- > > > How do I found id for Intel version so I can submit a patch? > > > > Try "pciconf -l | grep ^hdac". You'll see subvendor and subdevice. > --=20 Nuno Teixeira FreeBSD Committer (ports) --0000000000001acb2e05e727b9d9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Hi all!</div><div><br></div><div>patch ready and test= ed at PR <a href=3D"https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265= 632">265632</a></div><div><br></div><div>Cheers,<br></div></div><br><div cl= ass=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">Jung-uk Kim <<= a href=3D"mailto:jkim@freebsd.org">jkim@freebsd.org</a>> escreveu no dia= quinta, 25/08/2022 =C3=A0(s) 21:24:<br></div><blockquote class=3D"gmail_qu= ote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,20= 4);padding-left:1ex">On 22. 8. 25., Nuno Teixeira wrote:<br> > Hi!<br> > <br> > `pciconf -l | grep ^hdac`:<br> > ---<br> > hdac1@pci0:0:31:3: =C2=A0 =C2=A0 =C2=A0class=3D0x040380 rev=3D0x00 hdr= =3D0x00 vendor=3D0x8086 <br> > device=3D0x06c8 subvendor=3D0x17aa subdevice=3D0x380f<br> > ^^^^=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<br> > ^^^^^=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^^^^<br> > hdac0@pci0:1:0:1: =C2=A0 =C2=A0 =C2=A0 class=3D0x040300 rev=3D0xa1 hdr= =3D0x00 vendor=3D0x10de <br> > device=3D0x10fa subvendor=3D0x17aa subdevice=3D0x3ffb<br> > ---<br> > <br> > I think hdac1 is what I'm looking for:<br> > ---<br> > hdac1@pci0:0:31:3: =C2=A0 =C2=A0 =C2=A0class=3D0x040380 rev=3D0x00 hdr= =3D0x00 vendor=3D0x8086 <br> > device=3D0x06c8 subvendor=3D0x17aa subdevice=3D0x380f<br> >=C2=A0 =C2=A0 =C2=A0 vendor =C2=A0 =C2=A0 =3D 'Intel Corporation= 9;<br> >=C2=A0 =C2=A0 =C2=A0 device =C2=A0 =C2=A0 =3D 'Comet Lake PCH cAVS&= #39;<br> >=C2=A0 =C2=A0 =C2=A0 class =C2=A0 =C2=A0 =C2=A0=3D multimedia<br> >=C2=A0 =C2=A0 =C2=A0 subclass =C2=A0 =3D HDA<br> > ---<br> > <br> > (LENOVO_VENDORID =C2=A0 =C2=A0 =C2=A0 =C2=A0 0x17aa)<br> > <br> > maybe:<br> > #define LENOVO_L5INTEL_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x380f) ?= <br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<br> > ^^^^=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <br> > ^^^^<br> <br> I guess. :-)<br> <br> JK<br> <br> > Jung-uk Kim <<a href=3D"mailto:jkim@freebsd.org" target=3D"_blank">= jkim@freebsd.org</a> <mailto:<a href=3D"mailto:jkim@freebsd.org" target= =3D"_blank">jkim@freebsd.org</a>>> escreveu no dia <br> > quinta, 25/08/2022 =C3=A0(s) 20:15:<br> > <br> >=C2=A0 =C2=A0 =C2=A0On 22. 8. 25., Nuno Teixeira wrote:<br> >=C2=A0 =C2=A0 =C2=A0 > ** Same config were imported from D30333<br> >=C2=A0 =C2=A0 =C2=A0 > <<a href=3D"https://reviews.freebsd.org/D3= 0333" rel=3D"noreferrer" target=3D"_blank">https://reviews.freebsd.org/D303= 33</a><br> >=C2=A0 =C2=A0 =C2=A0<<a href=3D"https://reviews.freebsd.org/D30333" = rel=3D"noreferrer" target=3D"_blank">https://reviews.freebsd.org/D30333</a>= >>for Legion 5 AMD, PR 265632<br> >=C2=A0 =C2=A0 =C2=A0 > <<a href=3D"https://bugs.freebsd.org/bugzi= lla/show_bug.cgi?id=3D265632" rel=3D"noreferrer" target=3D"_blank">https://= bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265632</a><br> >=C2=A0 =C2=A0 =C2=A0<<a href=3D"https://bugs.freebsd.org/bugzilla/sh= ow_bug.cgi?id=3D265632" rel=3D"noreferrer" target=3D"_blank">https://bugs.f= reebsd.org/bugzilla/show_bug.cgi?id=3D265632</a>>>for Intel<br> >=C2=A0 =C2=A0 =C2=A0version<br> >=C2=A0 =C2=A0 =C2=A0 ><br> >=C2=A0 =C2=A0 =C2=A0 > Nuno Teixeira <<a href=3D"mailto:eduardo@f= reebsd.org" target=3D"_blank">eduardo@freebsd.org</a> <mailto:<a href=3D= "mailto:eduardo@freebsd.org" target=3D"_blank">eduardo@freebsd.org</a>><= br> >=C2=A0 =C2=A0 =C2=A0<mailto:<a href=3D"mailto:eduardo@freebsd.org" t= arget=3D"_blank">eduardo@freebsd.org</a> <mailto:<a href=3D"mailto:eduar= do@freebsd.org" target=3D"_blank">eduardo@freebsd.org</a>>>><br> >=C2=A0 =C2=A0 =C2=A0 > escreveu no dia quinta, 25/08/2022 =C3=A0(s) = 19:59:<br> >=C2=A0 =C2=A0 =C2=A0 ><br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0Hello,<br> >=C2=A0 =C2=A0 =C2=A0 ><br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0I have Lenovo Legion 5 Int= el speakers working ok with<br> >=C2=A0 =C2=A0 =C2=A0device.hints:<br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0---<br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0hint.hdaa.1.nid20.config= =3D"as=3D1 seq=3D0"<br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0hint.hdaa.1.nid33.config= =3D"as=3D1 seq=3D15"<br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0---<br> >=C2=A0 =C2=A0 =C2=A0 ><br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0Same config were imported = from D30333<br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0<<a href=3D"https://rev= iews.freebsd.org/D30333" rel=3D"noreferrer" target=3D"_blank">https://revie= ws.freebsd.org/D30333</a><br> >=C2=A0 =C2=A0 =C2=A0<<a href=3D"https://reviews.freebsd.org/D30333" = rel=3D"noreferrer" target=3D"_blank">https://reviews.freebsd.org/D30333</a>= >>and PR 265632<br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0<<a href=3D"https://bug= s.freebsd.org/bugzilla/show_bug.cgi?id=3D265632" rel=3D"noreferrer" target= =3D"_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265632</a><= br> >=C2=A0 =C2=A0 =C2=A0<<a href=3D"https://bugs.freebsd.org/bugzilla/sh= ow_bug.cgi?id=3D265632" rel=3D"noreferrer" target=3D"_blank">https://bugs.f= reebsd.org/bugzilla/show_bug.cgi?id=3D265632</a>>> for<br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0Legion 5 AMD:<br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0(sys/dev/sound/pci/hda/hda= c.h)<br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0---<br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0#define LENOVO_L5AMD_SUBVE= NDOR HDA_MODEL_CONSTRUCT(LENOVO,<br> >=C2=A0 =C2=A0 =C2=A00x381b)<br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0---<br> >=C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0How do I found id for Inte= l version so I can submit a patch?<br> > <br> >=C2=A0 =C2=A0 =C2=A0Try "pciconf -l | grep ^hdac".=C2=A0 You&= #39;ll see subvendor and subdevice.<br> </blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"g= mail_signature"><div dir=3D"ltr"><span style=3D"color:rgb(102,102,102)">Nun= o Teixeira<br>FreeBSD Committer (ports)</span></div></div> --0000000000001acb2e05e727b9d9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7ULdWYorTr0CZL=oDB6PyVVB5bEgcpCxLi4o=%2Bfjqd2Arw>