Date: Fri, 26 Aug 2022 17:51:07 +0100 From: Nuno Teixeira <eduardo@freebsd.org> To: Jung-uk Kim <jkim@freebsd.org> Cc: FreeBSD CURRENT <freebsd-current@freebsd.org> Subject: Re: Lenovo Legion 5 Intel speakers working ok! Message-ID: <CAFDf7ULdWYorTr0CZL=oDB6PyVVB5bEgcpCxLi4o=%2Bfjqd2Arw@mail.gmail.com> In-Reply-To: <385387e0-9dae-d797-1af0-05cd44b4300c@FreeBSD.org> References: <CAFDf7U%2BbEh6X8r3JPS=5dRbSZ8CJgF74kCM4uGEKVo6QZ9Ex2Q@mail.gmail.com> <CAFDf7UKSaMHMZCtsydS4no6YREYXa76Z4G3ZSZtxDLGga7iOng@mail.gmail.com> <94e271b7-3019-a377-bb8b-e681c78b0d82@FreeBSD.org> <CAFDf7U%2BDdFu14TupbSB5xu1JN=NhEJqF5M_h%2ByU2VKfkyzfxAQ@mail.gmail.com> <385387e0-9dae-d797-1af0-05cd44b4300c@FreeBSD.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Hi all! patch ready and tested at PR 265632 <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265632>; Cheers, Jung-uk Kim <jkim@freebsd.org> escreveu no dia quinta, 25/08/2022 à(s) 21:24: > On 22. 8. 25., Nuno Teixeira wrote: > > Hi! > > > > `pciconf -l | grep ^hdac`: > > --- > > hdac1@pci0:0:31:3: class=0x040380 rev=0x00 hdr=0x00 vendor=0x8086 > > device=0x06c8 subvendor=0x17aa subdevice=0x380f > > ^^^^ > > > > ^^^^^ ^^^^ > > hdac0@pci0:1:0:1: class=0x040300 rev=0xa1 hdr=0x00 vendor=0x10de > > device=0x10fa subvendor=0x17aa subdevice=0x3ffb > > --- > > > > I think hdac1 is what I'm looking for: > > --- > > hdac1@pci0:0:31:3: class=0x040380 rev=0x00 hdr=0x00 vendor=0x8086 > > device=0x06c8 subvendor=0x17aa subdevice=0x380f > > vendor = 'Intel Corporation' > > device = 'Comet Lake PCH cAVS' > > class = multimedia > > subclass = HDA > > --- > > > > (LENOVO_VENDORID 0x17aa) > > > > maybe: > > #define LENOVO_L5INTEL_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x380f) ? > > > > ^^^^ > > > ^^^^ > > I guess. :-) > > JK > > > Jung-uk Kim <jkim@freebsd.org <mailto:jkim@freebsd.org>> escreveu no > dia > > quinta, 25/08/2022 à(s) 20:15: > > > > On 22. 8. 25., Nuno Teixeira wrote: > > > ** Same config were imported from D30333 > > > <https://reviews.freebsd.org/D30333 > > <https://reviews.freebsd.org/D30333>>for Legion 5 AMD, PR 265632 > > > <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265632 > > <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265632>>for Intel > > version > > > > > > Nuno Teixeira <eduardo@freebsd.org <mailto:eduardo@freebsd.org> > > <mailto:eduardo@freebsd.org <mailto:eduardo@freebsd.org>>> > > > escreveu no dia quinta, 25/08/2022 à(s) 19:59: > > > > > > Hello, > > > > > > I have Lenovo Legion 5 Intel speakers working ok with > > device.hints: > > > --- > > > hint.hdaa.1.nid20.config="as=1 seq=0" > > > hint.hdaa.1.nid33.config="as=1 seq=15" > > > --- > > > > > > Same config were imported from D30333 > > > <https://reviews.freebsd.org/D30333 > > <https://reviews.freebsd.org/D30333>>and PR 265632 > > > <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265632 > > <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265632>>; for > > > Legion 5 AMD: > > > (sys/dev/sound/pci/hda/hdac.h) > > > --- > > > #define LENOVO_L5AMD_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, > > 0x381b) > > > --- > > > How do I found id for Intel version so I can submit a patch? > > > > Try "pciconf -l | grep ^hdac". You'll see subvendor and subdevice. > -- Nuno Teixeira FreeBSD Committer (ports) [-- Attachment #2 --] <div dir="ltr"><div>Hi all!</div><div><br></div><div>patch ready and tested at PR <a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265632">265632</a></div><div><br></div><div>Cheers,<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Jung-uk Kim <<a href="mailto:jkim@freebsd.org">jkim@freebsd.org</a>> escreveu no dia quinta, 25/08/2022 à(s) 21:24:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 22. 8. 25., Nuno Teixeira wrote:<br> > Hi!<br> > <br> > `pciconf -l | grep ^hdac`:<br> > ---<br> > hdac1@pci0:0:31:3: class=0x040380 rev=0x00 hdr=0x00 vendor=0x8086 <br> > device=0x06c8 subvendor=0x17aa subdevice=0x380f<br> > ^^^^ <br> > ^^^^^ ^^^^<br> > hdac0@pci0:1:0:1: class=0x040300 rev=0xa1 hdr=0x00 vendor=0x10de <br> > device=0x10fa subvendor=0x17aa subdevice=0x3ffb<br> > ---<br> > <br> > I think hdac1 is what I'm looking for:<br> > ---<br> > hdac1@pci0:0:31:3: class=0x040380 rev=0x00 hdr=0x00 vendor=0x8086 <br> > device=0x06c8 subvendor=0x17aa subdevice=0x380f<br> > vendor = 'Intel Corporation'<br> > device = 'Comet Lake PCH cAVS'<br> > class = multimedia<br> > subclass = HDA<br> > ---<br> > <br> > (LENOVO_VENDORID 0x17aa)<br> > <br> > maybe:<br> > #define LENOVO_L5INTEL_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO, 0x380f) ?<br> > <br> > ^^^^ <br> > ^^^^<br> <br> I guess. :-)<br> <br> JK<br> <br> > Jung-uk Kim <<a href="mailto:jkim@freebsd.org" target="_blank">jkim@freebsd.org</a> <mailto:<a href="mailto:jkim@freebsd.org" target="_blank">jkim@freebsd.org</a>>> escreveu no dia <br> > quinta, 25/08/2022 à(s) 20:15:<br> > <br> > On 22. 8. 25., Nuno Teixeira wrote:<br> > > ** Same config were imported from D30333<br> > > <<a href="https://reviews.freebsd.org/D30333" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D30333</a><br>; > <<a href="https://reviews.freebsd.org/D30333" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D30333</a>>>for Legion 5 AMD, PR 265632<br> > > <<a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265632" rel="noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265632</a><br>; > <<a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265632" rel="noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265632</a>>>for Intel<br> > version<br> > ><br> > > Nuno Teixeira <<a href="mailto:eduardo@freebsd.org" target="_blank">eduardo@freebsd.org</a> <mailto:<a href="mailto:eduardo@freebsd.org" target="_blank">eduardo@freebsd.org</a>><br> > <mailto:<a href="mailto:eduardo@freebsd.org" target="_blank">eduardo@freebsd.org</a> <mailto:<a href="mailto:eduardo@freebsd.org" target="_blank">eduardo@freebsd.org</a>>>><br> > > escreveu no dia quinta, 25/08/2022 à(s) 19:59:<br> > ><br> > > Hello,<br> > ><br> > > I have Lenovo Legion 5 Intel speakers working ok with<br> > device.hints:<br> > > ---<br> > > hint.hdaa.1.nid20.config="as=1 seq=0"<br> > > hint.hdaa.1.nid33.config="as=1 seq=15"<br> > > ---<br> > ><br> > > Same config were imported from D30333<br> > > <<a href="https://reviews.freebsd.org/D30333" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D30333</a><br>; > <<a href="https://reviews.freebsd.org/D30333" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D30333</a>>>and PR 265632<br> > > <<a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265632" rel="noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265632</a><br>; > <<a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265632" rel="noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265632</a>>> for<br> > > Legion 5 AMD:<br> > > (sys/dev/sound/pci/hda/hdac.h)<br> > > ---<br> > > #define LENOVO_L5AMD_SUBVENDOR HDA_MODEL_CONSTRUCT(LENOVO,<br> > 0x381b)<br> > > ---<br> > > How do I found id for Intel version so I can submit a patch?<br> > <br> > Try "pciconf -l | grep ^hdac". You'll see subvendor and subdevice.<br> </blockquote></div><br clear="all"><br>-- <br><div dir="ltr" class="gmail_signature"><div dir="ltr"><span style="color:rgb(102,102,102)">Nuno Teixeira<br>FreeBSD Committer (ports)</span></div></div>help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFDf7ULdWYorTr0CZL=oDB6PyVVB5bEgcpCxLi4o=%2Bfjqd2Arw>