Date: Mon, 25 Dec 2006 12:12:11 -0500 From: Scott Long <scottl@samsco.org> To: Luigi Rizzo <rizzo@icir.org> Cc: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua>, stable@freebsd.org Subject: Re: burncd 'blank' not terminating ? Message-ID: <4590066B.8050604@samsco.org> In-Reply-To: <20061225084704.A23448@xorpc.icir.org> References: <20061221092717.A6431@xorpc.icir.org> <20061222073857.GA10704@tmn.ru> <20061225165735.M22401@atlantis.atlantis.dp.ua> <20061225084704.A23448@xorpc.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Luigi Rizzo wrote:
> On Mon, Dec 25, 2006 at 05:12:04PM +0200, Dmitry Pryanishnikov wrote:
>> Hello!
>>
>> On Fri, 22 Dec 2006, Sergey N. Voronkov wrote:
>>>> just noticed, after upgrading to 6.2RC1, that
>>>>
>>>> luigi# burncd -f /dev/acd0 -v blank
>>>> blanking CD, please wait..
>>>>
>>>> stays there forever. Eventually i gave up and ctrl-C and
>>>> the application terminates, and i was able to write to
>>>> the disk a valid image, which probably means that the
>>>> disk had been blanked.
>> Yes, well known RELENG_4 -> 6 (maybe even 5) regression. Same here with
>>
>> acd0: CDRW <CD-W540E/1.0C> at ata1-master UDMA33
>>
>> Worked fine under RELENG_4, fails to wait for completion under RELENG_6.
>
> indeed, the two routines are different: in RELENG_4
>
> static int
> acd_get_progress(struct acd_softc *cdp, int *finished)
> {
> int8_t ccb[16] = { ATAPI_READ_CAPACITY, 0, 0, 0, 0, 0, 0, 0,
> 0, 0, 0, 0, 0, 0, 0, 0 };
My memory is rusty here, but I thought that a TUR was the canonical way
to test if the operation is complete, and get progress as a side effect.
I see that until rev 1.85, this function used a plain REQUEST_SENSE,
which was definitely wrong. There has to be some way that a
WHQL-qualified disc burner will report this information reliably.
Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4590066B.8050604>