Date: Wed, 6 Jun 2018 00:51:55 +0300 From: Andriy Gapon <avg@FreeBSD.org> To: Eric van Gyzen <vangyzen@freebsd.org>, Ian Lepore <ian@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334669 - head/sys/sys Message-ID: <3ec8b34a-7cc7-81a1-37e2-706da27ad1dc@FreeBSD.org> In-Reply-To: <a80e0090-614d-2753-97cc-d94cad6ecbdd@FreeBSD.org> References: <201806052034.w55KYBsb096418@repo.freebsd.org> <1528232004.63685.25.camel@freebsd.org> <a80e0090-614d-2753-97cc-d94cad6ecbdd@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/06/2018 00:07, Eric van Gyzen wrote: > On 06/05/2018 15:53, Ian Lepore wrote: >> This is a sad sad thing. Treating (bits & flagconstants) as boolean has >> a long long history in C. Surely there are literally thousand of >> occurrances in freebsd code already, so why did this one get flagged? > > I agree, and I tend to avoid adding "!= 0" unnecessarily, but I don't > feel very strongly about it. I am not sure what parts of code you work on, but turning bit operations into logical operations within conditions is the predominant FreeBSD style. Please accept it. -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3ec8b34a-7cc7-81a1-37e2-706da27ad1dc>