Date: Wed, 26 Aug 2020 20:33:54 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Ian Lepore <ian@FreeBSD.org> Cc: Mateusz Guzik <mjguzik@gmail.com>, Jung-uk Kim <jkim@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364822 - in head/crypto/openssl/crypto: aes/asm bn/asm chacha/asm ec/asm modes/asm poly1305/asm sha/asm Message-ID: <0FAD8A61-49D2-4419-8744-1BAE6DA9C6C2@FreeBSD.org> In-Reply-To: <7f1149b6e8dfd1600ff235b7b1aaae3b746b4a9f.camel@freebsd.org> References: <202008261655.07QGtSZx096979@repo.freebsd.org> <CAGudoHGfUpzbmjmd1Q=pG7LyOM3uCKEhq%2BiF6-X_p_SLKbyfVA@mail.gmail.com> <7f1149b6e8dfd1600ff235b7b1aaae3b746b4a9f.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_9A17FF09-2CB2-4A7B-B329-1371FDB9E3E6 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 26 Aug 2020, at 19:13, Ian Lepore <ian@FreeBSD.org> wrote: > > On Wed, 2020-08-26 at 19:04 +0200, Mateusz Guzik wrote: >> On 8/26/20, Jung-uk Kim <jkim@freebsd.org> wrote: >>> Author: jkim >>> Date: Wed Aug 26 16:55:28 2020 >>> New Revision: 364822 >>> URL: https://svnweb.freebsd.org/changeset/base/364822 >>> >>> Log: >>> Fix Clang version detection. >>> >>> We prepend "FreeBSD" to Clang version string. This broke >>> compiler test >>> for >>> AVX instruction support. >>> >> >> What about other software checking in similar fashion? imo the right >> fix is to stop mucking with the way clang reports itself >> > > Maybe it would be better to not modify the start of the string. > Instead of > > FreeBSD clang version 9.0.1 (git@github.com:llvm/llvm-project.git > c1a0a213378a458fbea1a5c77b315c7dce08fd05) (based on LLVM 9.0.1) > > maybe > > clang version 9.0.1 for FreeBSD (git@github.com:llvm/llvm-project.git > c1a0a213378a458fbea1a5c77b315c7dce08fd05) (based on LLVM 9.0.1) We have been doing this since, well, forever. And this way actually originates from upstream, we only define the CLANG_VENDOR macro. I see no reason to change this after all those years. A better question is, why these perl scripts "suddenly" started failing? Or have they also failed since forever, and it was only noticed now? -Dimitry --Apple-Mail=_9A17FF09-2CB2-4A7B-B329-1371FDB9E3E6 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCX0arEgAKCRCwXqMKLiCW o/9VAKCT6F/WSyi7cwXeJ7uGzED/1l8IQACfUWGC62pRYVUNKPMJBllgLLV4IO4= =1GGW -----END PGP SIGNATURE----- --Apple-Mail=_9A17FF09-2CB2-4A7B-B329-1371FDB9E3E6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0FAD8A61-49D2-4419-8744-1BAE6DA9C6C2>