Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 May 2019 08:18:28 -0400
From:      Ed Maste <emaste@freebsd.org>
To:        Ilya Bakulin <ilya@bakulin.de>
Cc:        freebsd-git@freebsd.org
Subject:   Re: Speeding up slower Git operations
Message-ID:  <CAPyFy2CAFJ1r26q3FsfTdmy-JsyPrxv5EPaaoZD=Egzs4T10xA@mail.gmail.com>
In-Reply-To: <CADzbx%2Bq=sn%2B_bqtwE65GjfkPYZLxpx0-cLLEvH6sisJ7M-QrWQ@mail.gmail.com>
References:  <CAPyFy2AWw0EaeThqpa2Gb9bJCnjb3UgHCARvdpUnh=Pp8mpKkA@mail.gmail.com> <CADzbx%2Bq=sn%2B_bqtwE65GjfkPYZLxpx0-cLLEvH6sisJ7M-QrWQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 28 May 2019 at 13:57, Ilya Bakulin <ilya@bakulin.de> wrote:
>
> You are counting commits behind HEAD which is a mere pointer to the curre=
nt branch head. So if you are working on some "topic" branch then the numbe=
r becomes effectively useless since it will count a number of commits behin=
d that topic branch HEAD. So this number alone is not sufficient unless you=
 also append "-dirty" or something else to denote the "canonical" build don=
e from a clean git checkout of the official FreeBSD repository. Which is a =
good idea anyway, I guess.

Correct. For builds of an unmodified upstream version the (branch,
rev-list --count) will be unique and consistent.

Today for builds from git we include in uname the corresponding SVN
version, the git hash, and the branch - e.g. a test machine here
reports "r333291+95e9f145d658(HEAD-TESTING)". I'm not sure what the
best way to report it would be, but in the absence of svn we could
indicate something like
"95e9f145d658(HEAD-TESTING) c251421".

> So that when somebody reports a bug on some mailing list and includes a k=
ernel version number (or freebsd-version output) it's immediately obvious t=
hat they are using a non-official kernel.

We do that today as well, appending -dirty for builds from a modified
git tree and M from a modified Subversion tree.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CAFJ1r26q3FsfTdmy-JsyPrxv5EPaaoZD=Egzs4T10xA>