Date: Sat, 22 Aug 2015 11:28:11 +0000 From: bugzilla-noreply@freebsd.org To: chromium@FreeBSD.org Subject: [Bug 202368] www/chromium: optionally build chromedriver Message-ID: <bug-202368-28929-86GapALP4U@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-202368-28929@https.bugs.freebsd.org/bugzilla/> References: <bug-202368-28929@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202368 stb@lassitu.de changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Closed |Open Resolution|FIXED |--- --- Comment #5 from stb@lassitu.de --- Unfortunately, the version committed doesn't work. DRIVER_MAKE_ARGS gets defined unconditionally, but is never used, and chromedriver is never built. Something like this is needed: Index: Makefile =================================================================== --- Makefile (revision 394932) +++ Makefile (working copy) @@ -196,6 +196,9 @@ GPERF="${LOCALBASE}/bin/gperf" MAKE_ARGS= -C out/${BUILDTYPE} DRIVER_MAKE_ARGS=chromedriver +.if ${PORT_OPTIONS:MDRIVER} +MAKE_ARGS+= ${DRIVER_MAKE_ARGS} +.endif .include <bsd.port.pre.mk> -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-202368-28929-86GapALP4U>