Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 Nov 2023 11:07:22 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        John Baldwin <jhb@freebsd.org>
Cc:        Warner Losh <imp@freebsd.org>, src-committers@freebsd.org,  dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 29363fb44637 - main - sys: Remove ancient SCCS tags.
Message-ID:  <CANCZdfpF33DgG2LYpWLipdjWeb2zw%2BmkzcDxTptPS%2BwcDVHyPA@mail.gmail.com>
In-Reply-To: <40aa8c4e-69c1-4549-b822-51187c3eb154@FreeBSD.org>
References:  <202311270524.3AR5Onom066066@gitrepo.freebsd.org> <40aa8c4e-69c1-4549-b822-51187c3eb154@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

[-- Attachment #1 --]
On Mon, Nov 27, 2023 at 10:50 AM John Baldwin <jhb@freebsd.org> wrote:

> On 11/26/23 9:24 PM, Warner Losh wrote:
> > The branch main has been updated by imp:
> >
> > URL:
> https://cgit.FreeBSD.org/src/commit/?id=29363fb446372cb3f10bc98664e9767c53fbb457
> >
> > commit 29363fb446372cb3f10bc98664e9767c53fbb457
> > Author:     Warner Losh <imp@FreeBSD.org>
> > AuthorDate: 2023-11-23 17:21:37 +0000
> > Commit:     Warner Losh <imp@FreeBSD.org>
> > CommitDate: 2023-11-27 05:23:30 +0000
> >
> >      sys: Remove ancient SCCS tags.
> >
> >      Remove ancient SCCS tags from the tree, automated scripting, with
> two
> >      minor fixup to keep things compiling. All the common forms in the
> tree
> >      were removed with a perl script.
> >
> >      Sponsored by:           Netflix
> > ---
> > diff --git a/sys/amd64/amd64/mem.c b/sys/amd64/amd64/mem.c
> > index 378cf2f011f6..e5285586b928 100644
> > --- a/sys/amd64/amd64/mem.c
> > +++ b/sys/amd64/amd64/mem.c
> > @@ -35,7 +35,6 @@
> >    * SUCH DAMAGE.
> >    *
> >    *  from: Utah $Hdr: mem.c 1.13 89/10/08$
> > - *   from: @(#)mem.c 7.2 (Berkeley) 5/9/91
> >    */
> >
> >   #include <sys/cdefs.h>
>
> Do we want to axe the Utah $Hdr lines as well?  Those are even older than
> UCB.
>

I think so.


> > diff --git a/sys/amd64/amd64/vm_machdep.c b/sys/amd64/amd64/vm_machdep.c
> > index 27bf3f67ca25..6173aabd97f5 100644
> > --- a/sys/amd64/amd64/vm_machdep.c
> > +++ b/sys/amd64/amd64/vm_machdep.c
> > @@ -37,8 +37,6 @@
> >    * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
> ANY WAY
> >    * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
> OF
> >    * SUCH DAMAGE.
> > - *
> > - *   from: @(#)vm_machdep.c  7.3 (Berkeley) 5/13/91
> >    *  Utah $Hdr: vm_machdep.c 1.16.1.1 89/06/23$
> >    */
> >
>
> This looks to be a bug in the script as it didn't leave a blank line
> before the Utah hdr.
>
> I'm fine if the fix is to can the Utah headers.
>

Ah, I hadn't even noticed the Utah headers there. There's a number of other
places in the tree that have $Id$ or similar things as well. There are
likely others
that we'll find. With tens of thousands of these in the tree, it's easy to
miss a few (I
think I missed about 100 $FreeBSD$'s that were spelled various ways that
were a
bit different than the scripts expected.

Warner

[-- Attachment #2 --]
<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Nov 27, 2023 at 10:50 AM John Baldwin &lt;<a href="mailto:jhb@freebsd.org">jhb@freebsd.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 11/26/23 9:24 PM, Warner Losh wrote:<br>
&gt; The branch main has been updated by imp:<br>
&gt; <br>
&gt; URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=29363fb446372cb3f10bc98664e9767c53fbb457" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=29363fb446372cb3f10bc98664e9767c53fbb457</a><br>;
&gt; <br>
&gt; commit 29363fb446372cb3f10bc98664e9767c53fbb457<br>
&gt; Author:     Warner Losh &lt;imp@FreeBSD.org&gt;<br>
&gt; AuthorDate: 2023-11-23 17:21:37 +0000<br>
&gt; Commit:     Warner Losh &lt;imp@FreeBSD.org&gt;<br>
&gt; CommitDate: 2023-11-27 05:23:30 +0000<br>
&gt; <br>
&gt;      sys: Remove ancient SCCS tags.<br>
&gt;      <br>
&gt;      Remove ancient SCCS tags from the tree, automated scripting, with two<br>
&gt;      minor fixup to keep things compiling. All the common forms in the tree<br>
&gt;      were removed with a perl script.<br>
&gt;      <br>
&gt;      Sponsored by:           Netflix<br>
&gt; ---<br>
&gt; diff --git a/sys/amd64/amd64/mem.c b/sys/amd64/amd64/mem.c<br>
&gt; index 378cf2f011f6..e5285586b928 100644<br>
&gt; --- a/sys/amd64/amd64/mem.c<br>
&gt; +++ b/sys/amd64/amd64/mem.c<br>
&gt; @@ -35,7 +35,6 @@<br>
&gt;    * SUCH DAMAGE.<br>
&gt;    *<br>
&gt;    *  from: Utah $Hdr: mem.c 1.13 89/10/08$<br>
&gt; - *   from: @(#)mem.c 7.2 (Berkeley) 5/9/91<br>
&gt;    */<br>
&gt;   <br>
&gt;   #include &lt;sys/cdefs.h&gt;<br>
<br>
Do we want to axe the Utah $Hdr lines as well?  Those are even older than UCB.<br></blockquote><div><br></div><div>I think so.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
&gt; diff --git a/sys/amd64/amd64/vm_machdep.c b/sys/amd64/amd64/vm_machdep.c<br>
&gt; index 27bf3f67ca25..6173aabd97f5 100644<br>
&gt; --- a/sys/amd64/amd64/vm_machdep.c<br>
&gt; +++ b/sys/amd64/amd64/vm_machdep.c<br>
&gt; @@ -37,8 +37,6 @@<br>
&gt;    * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY<br>
&gt;    * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF<br>
&gt;    * SUCH DAMAGE.<br>
&gt; - *<br>
&gt; - *   from: @(#)vm_machdep.c  7.3 (Berkeley) 5/13/91<br>
&gt;    *  Utah $Hdr: vm_machdep.c 1.16.1.1 89/06/23$<br>
&gt;    */<br>
&gt;   <br>
<br>
This looks to be a bug in the script as it didn&#39;t leave a blank line before the Utah hdr.<br>
<br>
I&#39;m fine if the fix is to can the Utah headers.<br></blockquote><div><br></div><div>Ah, I hadn&#39;t even noticed the Utah headers there. There&#39;s a number of other</div><div>places in the tree that have $Id$ or similar things as well. There are likely others</div><div>that we&#39;ll find. With tens of thousands of these in the tree, it&#39;s easy to miss a few (I</div><div>think I missed about 100 $FreeBSD$&#39;s that were spelled various ways that were a</div><div>bit different than the scripts expected.</div><div><br></div><div>Warner</div></div></div>

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpF33DgG2LYpWLipdjWeb2zw%2BmkzcDxTptPS%2BwcDVHyPA>