Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 22 Jul 2012 11:00:02 +0000 (UTC)
From:      Isabell Long <issyl0@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org
Subject:   svn commit: r238683 - in stable/9: sbin/ipfw sys/netinet/ipfw
Message-ID:  <201207221100.q6MB02Ri075435@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: issyl0 (doc committer)
Date: Sun Jul 22 11:00:02 2012
New Revision: 238683
URL: http://svn.freebsd.org/changeset/base/238683

Log:
  MFC r238063:
   - Make ipfw's sched rules case insensitive, for user-friendliness.
   - Add a note to the ipfw(8) man page about the rules no longer being
   case sensitive.
   - Fix some typos in the man page.
  
  PR:		docs/164772
  Reviewed by:	bz
  Approved by:	gavin
  Approved by:	re (kib)

Modified:
  stable/9/sbin/ipfw/ipfw.8
  stable/9/sys/netinet/ipfw/ip_dummynet.c

Modified: stable/9/sbin/ipfw/ipfw.8
==============================================================================
--- stable/9/sbin/ipfw/ipfw.8	Sun Jul 22 10:21:42 2012	(r238682)
+++ stable/9/sbin/ipfw/ipfw.8	Sun Jul 22 11:00:02 2012	(r238683)
@@ -1,7 +1,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd March 9, 2012
+.Dd July 3, 2012
 .Dt IPFW 8
 .Os
 .Sh NAME
@@ -2225,19 +2225,20 @@ Specifies the weight to be used for flow
 The weight must be in the range 1..100, and defaults to 1.
 .El
 .Pp
-The following parameters can be configured for a scheduler:
+The following case-insensitive parameters can be configured for a
+scheduler:
 .Pp
 .Bl -tag -width indent -compact
-.It Cm type Ar {fifo | wf2qp | rr | qfq}
+.It Cm type Ar {fifo | wf2q+ | rr | qfq}
 specifies the scheduling algorithm to use.
 .Bl -tag -width indent -compact
-.It cm fifo
+.It Cm fifo
 is just a FIFO scheduler (which means that all packets
 are stored in the same queue as they arrive to the scheduler).
 FIFO has O(1) per-packet time complexity, with very low
 constants (estimate 60-80ns on a 2GHz desktop machine)
 but gives no service guarantees.
-.It Cm wf2qp
+.It Cm wf2q+
 implements the WF2Q+ algorithm, which is a Weighted Fair Queueing
 algorithm which permits flows to share bandwidth according to
 their weights. Note that weights are not priorities; even a flow

Modified: stable/9/sys/netinet/ipfw/ip_dummynet.c
==============================================================================
--- stable/9/sys/netinet/ipfw/ip_dummynet.c	Sun Jul 22 10:21:42 2012	(r238682)
+++ stable/9/sys/netinet/ipfw/ip_dummynet.c	Sun Jul 22 11:00:02 2012	(r238683)
@@ -97,7 +97,7 @@ find_sched_type(int type, char *name)
 	struct dn_alg *d;
 
 	SLIST_FOREACH(d, &dn_cfg.schedlist, next) {
-		if (d->type == type || (name && !strcmp(d->name, name)))
+		if (d->type == type || (name && !strcasecmp(d->name, name)))
 			return d;
 	}
 	return NULL; /* not found */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201207221100.q6MB02Ri075435>