Date: Tue, 22 Aug 2023 15:24:50 -0600 From: Warner Losh <imp@bsdimp.com> To: Kristof Provost <kp@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, Sumit Saxena <sumit.saxena@broadcom.com>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 91fcacc35597 - main - if_bnxt: Add support for VLAN on Thor Message-ID: <CANCZdfq7T9VSWoaxU8H=RmfEKgRfTMiFiAtZy9sSjnXATLY07Q@mail.gmail.com> In-Reply-To: <05979953-C089-4D56-99E3-BBBF066FE277@FreeBSD.org> References: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org> <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org> <05979953-C089-4D56-99E3-BBBF066FE277@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Tue, Aug 22, 2023 at 3:07 PM Kristof Provost <kp@freebsd.org> wrote: > On 27 Jun 2023, at 11:17, Kristof Provost wrote: > > On 4 Nov 2022, at 23:55, Warner Losh wrote: > > The branch main has been updated by imp: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=91fcacc355971f74aa26fc7861020dc3a2a2d717 > > commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 > Author: Sumit Saxena <sumit.saxena@broadcom.com> > AuthorDate: 2022-11-04 22:24:32 +0000 > Commit: Warner Losh <imp@FreeBSD.org> > CommitDate: 2022-11-04 22:24:32 +0000 > > if_bnxt: Add support for VLAN on Thor > > Reviewed by: imp > Differential Revision: https://reviews.freebsd.org/D36443 > --- > sys/dev/bnxt/bnxt.h | 3 +- > sys/dev/bnxt/bnxt_hwrm.c | 110 > ++++++++++++++++++++++++++++------------------- > sys/dev/bnxt/bnxt_hwrm.h | 7 ++- > sys/dev/bnxt/if_bnxt.c | 7 ++- > 4 files changed, 74 insertions(+), 53 deletions(-) > > This commit appears to have broken vlan on these interfaces. > My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in a > Dell T640, if that helps). > > A simple vlan creation on top of one: > ifconfig vlan create > ifconfig vlan0 vlan 201 vlandev bnxt0 > > Results in a loss of connectivity. The kernel logs this, which I assume is > related: > > `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS error.` > > After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) I can > create vlan interfaces on top of bnxt0 without losing connectivity. > > Should we revert this before 14.0? > > There’s also a report of what I think is the same issue in > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269133 > > There’s a proposed patch there, but it did not work for me. > I think we're going to need to, unless Sumit and/or the broadcom team has a solution. This bug is biting more people than the bugs it supposedly fixed. Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 22, 2023 at 3:07 PM Kristof Provost <<a href="mailto:kp@freebsd.org">kp@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><u></u> <div><div style="font-family:sans-serif"><div style="white-space:normal"> <p dir="auto">On 27 Jun 2023, at 11:17, Kristof Provost wrote:</p> </div><div style="white-space:normal"><blockquote style="margin:0px 0px 5px;padding-left:5px;border-left:2px solid rgb(19,107,206);color:rgb(19,107,206)"><p dir="auto">On 4 Nov 2022, at 23:55, Warner Losh wrote:</p> <blockquote style="margin:0px 0px 5px;padding-left:5px;border-left:2px solid rgb(75,137,207);color:rgb(75,137,207)"><p dir="auto">The branch main has been updated by imp:</p> <p dir="auto">URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=91fcacc355971f74aa26fc7861020dc3a2a2d717" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=91fcacc355971f74aa26fc7861020dc3a2a2d717</a></p>; <p dir="auto">commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 <br> Author: Sumit Saxena <<a href="mailto:sumit.saxena@broadcom.com" target="_blank">sumit.saxena@broadcom.com</a>> <br> AuthorDate: 2022-11-04 22:24:32 +0000 <br> Commit: Warner Losh <imp@FreeBSD.org> <br> CommitDate: 2022-11-04 22:24:32 +0000</p> <p dir="auto"> if_bnxt: Add support for VLAN on Thor</p> <p dir="auto"> Reviewed by: imp <br> Differential Revision: <a href="https://reviews.freebsd.org/D36443" target="_blank">https://reviews.freebsd.org/D36443</a>; <br> --- <br> sys/dev/bnxt/bnxt.h | 3 +- <br> sys/dev/bnxt/bnxt_hwrm.c | 110 ++++++++++++++++++++++++++++------------------- <br> sys/dev/bnxt/bnxt_hwrm.h | 7 ++- <br> sys/dev/bnxt/if_bnxt.c | 7 ++- <br> 4 files changed, 74 insertions(+), 53 deletions(-)</p> </blockquote><p dir="auto">This commit appears to have broken vlan on these interfaces. <br> My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in a Dell T640, if that helps).</p> <p dir="auto">A simple vlan creation on top of one: <br> ifconfig vlan create <br> ifconfig vlan0 vlan 201 vlandev bnxt0</p> <p dir="auto">Results in a loss of connectivity. The kernel logs this, which I assume is related:</p> <p dir="auto">`bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS error.`</p> <p dir="auto">After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) I can create vlan interfaces on top of bnxt0 without losing connectivity.</p> <br></blockquote></div> <div style="white-space:normal"> <p dir="auto">Should we revert this before 14.0?</p> <p dir="auto">There’s also a report of what I think is the same issue in <a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269133" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269133</a></p>; <p dir="auto">There’s a proposed patch there, but it did not work for me.</p></div></div></div></blockquote><div><br></div><div>I think we're going to need to, unless Sumit and/or the broadcom team has a solution. This bug is biting more people than the bugs it supposedly fixed.</div><div><br></div><div>Warner </div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfq7T9VSWoaxU8H=RmfEKgRfTMiFiAtZy9sSjnXATLY07Q>