Date: Fri, 14 Feb 2003 15:51:47 -0600 From: Juli Mallett <jmallett@FreeBSD.org> To: Alfred Perlstein <alfred@FreeBSD.ORG>, Sam Leffler <sam@errno.com>, src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_shutdown.c Message-ID: <20030214155147.A79372@FreeBSD.org> In-Reply-To: <20030214214748.GA2520@HAL9000.homeunix.com>; from dschultz@uclink.Berkeley.EDU on Fri, Feb 14, 2003 at 01:47:48PM -0800 References: <200302141244.h1ECimG1059062@repoman.freebsd.org> <275601c2d43b$ebd9e580$52557f42@errno.com> <20030214191957.GO93252@elvis.mu.org> <20030214214748.GA2520@HAL9000.homeunix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* De: David Schultz <dschultz@uclink.Berkeley.EDU> [ Data: 2003-02-14 ] [ Subjecte: Re: cvs commit: src/sys/kern kern_shutdown.c ] > Thus spake Alfred Perlstein <alfred@FreeBSD.ORG>: > > * Sam Leffler <sam@errno.com> [030214 07:15] wrote: > > > > style. > > > More like "gratuitous style". > > More like when looking at the file in otder to fix other things I was so > > turned off by it that it offended me and for that reason needed fixing. > > A single extra space at the end of a line offends you? Some of > the ``style problems'' fixed by this commit aren't even in > style(9). However, the following IS in style(9): > > Stylistic changes (including whitespace changes) are hard > on the source repository and are to be avoided without > good reason. I got the impression he might be doing work on said file, in which case people prefer if you commit style changes seperately, if you do make them. Sweeping the tree for style reasons sucks unless there's some sort of marginally good reason, or you're doing it as part of something else. For example, when cleaning all the __P out of our OOL, it'd have made sense to adjust nearby line lengths and comments so the stylistic consistency would remain. juli. -- Juli Mallett <jmallett@FreeBSD.org> AIM: BSDFlata -- IRC: juli on EFnet OpenDarwin, Mono, FreeBSD Developer ircd-hybrid Developer, EFnet addict FreeBSD on MIPS-Anything on FreeBSD Never trust an ELF, COFF or Mach-O! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030214155147.A79372>