Date: Thu, 1 Feb 2018 16:10:53 -0800 From: Conrad Meyer <cem@freebsd.org> To: Kirk McKusick <mckusick@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328763 - head/sbin/fsck_ffs Message-ID: <CAG6CVpXus=Vt%2BOZUTWDV1TqDvLCw1yhKMZSrA9j%2B2axdv8OONg@mail.gmail.com> In-Reply-To: <201802020007.w1207dWn067046@repo.freebsd.org> References: <201802020007.w1207dWn067046@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
There's one last sbwrite() in fsck_ffs, in the gjournal code. Is that one known to be safe, or should it also use sbput()? Best, Conrad On Thu, Feb 1, 2018 at 4:07 PM, Kirk McKusick <mckusick@freebsd.org> wrote: > Author: mckusick > Date: Fri Feb 2 00:07:38 2018 > New Revision: 328763 > URL: https://svnweb.freebsd.org/changeset/base/328763 > > Log: > Use sbput(3) rather than sbwrite(3) to ensure that the updated copy of > the superblock gets written. > > Reported by: Mark Johnston <markj@FreeBSD.org> > > Modified: > head/sbin/fsck_ffs/suj.c > > Modified: head/sbin/fsck_ffs/suj.c > ============================================================================== > --- head/sbin/fsck_ffs/suj.c Fri Feb 2 00:01:50 2018 (r328762) > +++ head/sbin/fsck_ffs/suj.c Fri Feb 2 00:07:38 2018 (r328763) > @@ -213,8 +213,8 @@ closedisk(const char *devnam) > fs->fs_clean = 1; > fs->fs_time = time(NULL); > fs->fs_mtime = time(NULL); > - if (sbwrite(&disk, 0) == -1) > - err(EX_OSERR, "sbwrite(%s)", devnam); > + if (sbput(disk.d_fd, fs, 0) == -1) > + err(EX_OSERR, "sbput(%s)", devnam); > if (ufs_disk_close(&disk) == -1) > err(EX_OSERR, "ufs_disk_close(%s)", devnam); > fs = NULL; >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpXus=Vt%2BOZUTWDV1TqDvLCw1yhKMZSrA9j%2B2axdv8OONg>