Date: Mon, 31 Jul 2023 09:47:52 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Robert Clausecker <fuz@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org Subject: Re: git: 3af2e89732ee - 2023Q3 - graphics/gegl: fix build on armv7 Message-ID: <ZMdnKNEP0_wlY1Aw@KGPE-D16> In-Reply-To: <202307302302.36UN2Bdi018404@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] Wouldn't it be better to do it similarly to other ports? .if !exists(/usr/include/omp.h) MESON_ARGS+= -Dopenmp=disabled .endif This would also fix build on other OpenMP-less architectures and if a user on OpenMP-enabled architecture decides to build base with libomp. On 23-07-30 23:02:11, Robert Clausecker wrote: > The branch 2023Q3 has been updated by fuz: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3af2e89732ee15c2b8c39e8ec5a0f97ebc66635d > > commit 3af2e89732ee15c2b8c39e8ec5a0f97ebc66635d > Author: Robert Clausecker <fuz@FreeBSD.org> > AuthorDate: 2023-07-28 21:01:02 +0000 > Commit: Robert Clausecker <fuz@FreeBSD.org> > CommitDate: 2023-07-30 23:01:42 +0000 > > graphics/gegl: fix build on armv7 > > OpenMP is not supported on armv7. Fix the build by disabling its use. > > Approved by: portmgr (build fix blanket) > MFH: 2023Q3 > > (cherry picked from commit 9e2602394b77661efe58bb191416048e3ca7c7c7) > --- > graphics/gegl/Makefile | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/graphics/gegl/Makefile b/graphics/gegl/Makefile > index 6fbbd2446c43..9e1784ebd599 100644 > --- a/graphics/gegl/Makefile > +++ b/graphics/gegl/Makefile > @@ -33,7 +33,10 @@ MESON_ARGS= -Ddocs=false \ > -Dmaxflow=disabled \ > -Dmrg=disabled \ > -Dpygobject=disabled \ > - -Dlua=disabled > + -Dlua=disabled \ > + ${MESON_ARGS_${ARCH}} > +MESON_ARGS_armv6= -Dopenmp=disabled > +MESON_ARGS_armv7= -Dopenmp=disabled > > GEGL_SHLIB= 0.443.1 > GEGL_VER= 0.4 [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmTHZygACgkQelmbhSCD nJ3J6w//QWZnz51eGvyoTlJivhA6Xt0TZ84GyUL2Sh1fx4aSoy93h/u93Il4HvaF LkilEUuYEVHnctv4dvBCZjGeTj9bt5YrO7Pzj1ct6KrLvWasYkSOZSKJbMeMB+iw n5qDF6lLI94sJnUz2owTNBI+niHvUukSzNy5YY/GWys/K5EZFAkhHtwVW4Vpw7hW vRuV2HMvbBKfLJUJw5OFYgaYXG55+4UKIzwAVznL8DOrxJ6Rtc2X+vTn2obuA9Kp RpJ9UAmYlsSLJe2C69ekxXQC2P9m1IHrx6QFqR11OBmx3Rt2ZPQch2Sw338gQAgc D/Oqhl6cwCQ7l41aJy4Ib0MZ3Ud8Qvq51N8MoJYHFPOn4Zfi5JIHnmTOHW9x7XLP h7N1SjBGSsM1PFkQMq6l/lfkC5z1GFc2uYov60rU6o44wmHh39McMWCFGELGIuYY 7qEcE2q80whIE0lVH6e6h9ZbMqUlNQ2uLt4AYRWj4bqqpnmAEgPQezTp42wRlieE mrgPquiIfSGmZKc4Rx2p7PvpPpKifkLljrhL07BFz0JyLiMhDYbCOT6pwd0CCLkk RWFEICx1uEz2j3MLMQjWdm+87TCRkDxtoAeRfD4A3t3EXJCg9SJra91mYoJGNWbR F5zlp8kxHZA14ZHJCrSK2XBRpht6rEgzaEZLlWIZ62lF7VrDEVk= =DIsK -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZMdnKNEP0_wlY1Aw>