Date: Tue, 31 Jan 2006 08:36:53 +0100 (CET) From: Michael Nottebrock <lofi@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/92586: Don't warn about libtool archives for KDE ports. Message-ID: <200601310736.k0V7arps089944@vm-kiste.my.domain> Resent-Message-ID: <200601310740.k0V7e3lq033669@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 92586
>Category: ports
>Synopsis: Don't warn about libtool archives for KDE ports.
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Tue Jan 31 07:40:03 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator: Michael Nottebrock
>Release: FreeBSD 5.4-STABLE i386
>Organization:
>Environment:
System: FreeBSD vm-kiste 5.4-STABLE FreeBSD 5.4-STABLE #1: Sun Oct 16 18:16:21 CEST 2005 root@kiste:/usr/obj/usr/src/sys/KISTE-UP i386
>Description:
Portlint in maintainer mode currently warns about libtool archives in pkg-plist. KDE
applications however need those for correct operation (and bsd.autotools.mk will in
fact prevent ports with both USE_KDELIBS_VER and USE_AUTOTOOLS=libtool set from
building soon).
The attached patch disables the warning if USE_KDELIBS_VER is set in a port's
Makefile.
>How-To-Repeat:
>Fix:
--- portlint.pl.diff begins here ---
Index: portlint.pl
===================================================================
RCS file: /home/pcvs/ports/devel/portlint/src/portlint.pl,v
retrieving revision 1.83
diff -u -r1.83 portlint.pl
--- portlint.pl 22 Jan 2006 00:45:00 -0000 1.83
+++ portlint.pl 31 Jan 2006 07:04:17 -0000
@@ -176,7 +176,7 @@
PKGDIR COMMENT DESCR PLIST PKGCATEGORY PKGINSTALL PKGDEINSTALL
PKGREQ PKGMESSAGE MD5_FILE .CURDIR INSTALLS_SHLIB USE_AUTOTOOLS
INDEXFILE PKGORIGIN CONFLICTS PKG_VERSION PKGINSTALLVER
- PLIST_FILES OPTIONS INSTALLS_OMF
+ PLIST_FILES OPTIONS INSTALLS_OMF USE_KDELIBS_VER
);
my $cmd = join(' -V ', "make $makeenv MASTER_SITE_BACKUP=''", @varlist);
@@ -667,7 +667,7 @@
"for more details.");
}
- if ($_ =~ /\.la$/ && $makevar{USE_AUTOTOOLS} =~ 'libtool') {
+ if ($_ =~ /\.la$/ && $makevar{USE_AUTOTOOLS} =~ 'libtool' && !defined($makevar{USE_KDELIBS_VER})) {
&perror("WARN: $file [$.]: installing libtool archives, ".
"please use USE_AUTOTOOLS in Makefile if possible. ".
"See http://www.FreeBSD.org/gnome/docs/porting.html ".
--- portlint.pl.diff ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200601310736.k0V7arps089944>