Date: Wed, 30 Jan 2002 15:18:27 -0500 (EST) From: Trevor Johnson <trevor@jpj.net> To: Bill Fenner <fenner@research.att.com> Cc: cvs-committers@freebsd.org, <cvs-all@freebsd.org> Subject: Re: cvs commit: ports/www/linux-netscape6 Makefile Message-ID: <20020130151738.Y17949-100000@blues.jpj.net> In-Reply-To: <200201291624.IAA14538@windsor.research.att.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Bill Fenner wrote: > > >Your survey is a valuable resource for porters, and I didn't mean to > >disrupt it. However, from looking at > >http://people.freebsd.org/~fenner/portsurvey/www.html#linux-netscape6 I > >get no clue about what I broke. Could you please explain in detail? > >Otherwise, it's likely that I (or someone else) will cause a similar > >problem in the future. > > The Makefile tries to cat a file that doesn't exist. These results > only show up in my email and not on the web page, since usually any > output possibly means a broken port. It wasn't disruptive to the > port survey; sorry if the commit message implied that it was. > > >Whatever the trouble was, I have a feeling that your change might not > >eliminate it. You added a test for the existence of components.conf, > >which you do after the (interactive) configure script runs. > > No, the Makefile will try to read components.conf every time it is > read, even in a freshly checked out ports directory. Try it -- do a > "make distclean", then "make" and count the number of times that you > see > > cat: /usr/ports/www/linux-netscape6/work//netscape-installer/xpi/components.conf: No such file or directory > > even before running the script. My patch simply avoided those errors. Your patch broke "make install". -- Trevor Johnson To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020130151738.Y17949-100000>