Date: Thu, 5 Nov 2015 15:36:02 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Ian Lepore <ian@freebsd.org>, "O'Connor, Daniel" <darius@dons.net.au>, Adrian Chadd <adrian@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290428 - head/share/man/man9 Message-ID: <563BE7E2.4020402@FreeBSD.org> In-Reply-To: <1446766105.91534.407.camel@freebsd.org> References: <201511052250.tA5MoMOk060206@repo.freebsd.org> <84180B50-DEE2-454F-BD8E-C7F1B97CD301@dons.net.au> <1446766105.91534.407.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --4gDnCo78qDEc5euttFEHe23GFLqTC54Q3 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 11/5/2015 3:28 PM, Ian Lepore wrote: > On Fri, 2015-11-06 at 09:37 +1030, O'Connor, Daniel wrote: >> Presumably the intent was to have an extra line after the \ so diffs >> are reduced for future additions. >> >=20 > Yeah. I wish we did that pretty much universally wherever lists of > things appear (SRCS and OBJS lists in makefiles, a trailing comma on ar= > ray and enum init lists in C, etc). >=20 Me too. It leads to bugs like this though when an empty line does not follow. We've done this pattern at work but I avoid doing so here. >=20 >>> On 6 Nov 2015, at 09:20, Adrian Chadd <adrian@freebsd.org> wrote: >>> >>> Author: adrian >>> Date: Thu Nov 5 22:50:21 2015 >>> New Revision: 290428 >>> URL: https://svnweb.freebsd.org/changeset/base/290428 >>> >>> Log: >>> remove \, it confuses things. >>> >>> Modified: >>> head/share/man/man9/Makefile >>> >>> Modified: head/share/man/man9/Makefile >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>> --- head/share/man/man9/Makefile Thu Nov 5 22:44:36 2015=09 >>> (r290427) >>> +++ head/share/man/man9/Makefile Thu Nov 5 22:50:21 2015=09 >>> (r290428) >>> @@ -1294,7 +1294,7 @@ MLINKS+=3Dpci.9 pci_alloc_msi.9 \ >>> pci.9 pci_write_config.9 \ >>> pci.9 pcie_adjust_config.9 \ >>> pci.9 pcie_read_config.9 \ >>> - pci.9 pcie_write_config.9 \ >>> + pci.9 pcie_write_config.9 >>> MLINKS+=3Dpci_iov_schema.9 pci_iov_schema_alloc_node.9 \ >>> pci_iov_schema.9 pci_iov_schema_add_bool.9 \ >>> pci_iov_schema.9 pci_iov_schema_add_string.9 \ --=20 Regards, Bryan Drewery --4gDnCo78qDEc5euttFEHe23GFLqTC54Q3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWO+fiAAoJEDXXcbtuRpfPiAMH/R1EEsMnFXqT0iGFYhmkJg3Z HvKN4ZBfBqfwQdZXTxT1tLBo2vRFlx3cjfeczp42Nze5tFlc/8WpQLXAiMZ2cgJW 0tLOTgjKwpn4jYMJKVJ/IfebY+aqosxaCy56ynMmxZKB9XyFROfkLwOojlO3AQYl XyWbLkmGhkZasgJJ64OvYdZgaZ/Q6QvTYlxHb8H/yvVMXi/7phuM1DfkXpEJnb/X mWuWKryeVA/mRzjbH4BA8wCWBpt/doQ8XNk/6AFV7lxvOG+PANh/ukrsXQFIUyuS CKIQE+kob1ToehsPvnGQzFAg1pDop0Uhf2IhMjZ8YizoXOrJSLsy4ywWJ4OyBpY= =SRrx -----END PGP SIGNATURE----- --4gDnCo78qDEc5euttFEHe23GFLqTC54Q3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?563BE7E2.4020402>