Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Nov 2008 19:58:56 -0000
From:      Joseph Koshy <jkoshy@FreeBSD.org>
To:        Dag-Erling =?ISO-8859-1?Q?Sm=F8rgrav?= <des@des.no>
Cc:        svn-src-head@freebsd.org, Joseph Koshy <jkoshy@FreeBSD.org>, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r184994 - head/sys/dev/hwpmc
Message-ID:  <86hc5z7csx.wl%koshy@unixconsulting.co.in>
In-Reply-To: <863ahlpi4q.fsf@ds4.des.no>
References:  <200811151111.mAFBBWnf019276@svn.freebsd.org> <863ahlpi4q.fsf@ds4.des.no>

next in thread | previous in thread | raw e-mail | index | archive | help

> Joseph Koshy <jkoshy@FreeBSD.org> writes:
> > Modified: head/sys/dev/hwpmc/hwpmc_mod.c
> > ==============================================================================
> > --- head/sys/dev/hwpmc/hwpmc_mod.c	Sat Nov 15 11:07:54 2008	(r184993)
> > +++ head/sys/dev/hwpmc/hwpmc_mod.c	Sat Nov 15 11:11:32 2008	(r184994)
> > @@ -4656,6 +4656,9 @@ pmc_cleanup(void)
> >  			if (md->pmd_pcpu_fini)
> >  				md->pmd_pcpu_fini(cpu);
> >  		}
> > +
> > +		pmc_md_finalize(md);
> > +
> >  		free(md, M_PMC);
> >  		md = NULL;
> >  		pmc_restore_cpu_binding(&pb);
> 
> This breaks the ia64, powerpc and sparc64 builds; pmc_md_finalize() is
> only defined for i386 and amd64.

Oh, ugh.  Apologies.  Should be fixed now.

Koshy



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86hc5z7csx.wl%koshy>