Date: Wed, 20 Jan 2016 12:05:49 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 205805] Mk/bsd.qt.mk: Update to 5.5.1 Message-ID: <bug-205805-13-ZfN1Hll5k0@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-205805-13@https.bugs.freebsd.org/bugzilla/> References: <bug-205805-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D205805 --- Comment #13 from Raphael Kubo da Costa <rakuco@FreeBSD.org> --- (In reply to Raphael Kubo da Costa from comment #12) > I'll post some specific questions later. OK, here we go. I hope you're still around to look at the comments, answer = them and hopefully start contributing to our experimental repositories in the future. First, some comments about things which have been fixed or implemented differently in area51: * Changes in USE_QT5 in many ports: this prompted me to take a look at the situation. Indeed we were linking against many libraries without declaring them. However, I chose to fix it differently, and instead of just adjusting USE_QT5 I switched to building the Qt5 ports with -Wl,--as-needed so that t= he final binaries only really link against the libraries that they actually ne= ed. See http://src.mouf.net/area51/revision?rev=3D11818 and http://src.mouf.net/area51/revision/?rev=3D11827. * Adding USE_QT5=3Dwebchannel to webkit-qt5 doesn't make much sense, and ad= ding gstreamer-0.10 as a dependency is wrong. It must use GStreamer 1.0, like it already does. Ditto for qt5-multimedia. * Your change to qt5-printsupport's Makefile was partially right, see comme= nt #10 for all the required changes. * I've net/libproxy as a dependency for net/qt5-network following your chan= ge. It required some additional work: http://src.mouf.net/area51/revision/?rev=3D11824 * The patches you've added to qt5-core are wrong, see their versions in are= a51. Basically those things have all been fixed upstream, and importing the patc= hes from there is the right thing to do. Now things that still need clarification from your patch: * Why was patch-src__designer__src__src.pro removed from devel/qt5-uitools? * Why the changes to the filterLibraryOptions calls in extrapatch-configure? * I don't get why you added USES=3Dgettext to several ports. * I don't get why you need the post-patch changes you added to qt5-gui. * I don't get any of the PCRE-related changes you've made to qt5-core and q= t5. * Why was patch-3rdparty__clucene__src__CLucene__search__FieldCacheImpl.cpp removed from textproc/clucene-qt5? It was originally added because of bug 169872. It might not be needed anymore, but I need more context and confirmation that you tested it. --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-205805-13-ZfN1Hll5k0>