Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 8 May 2019 10:51:29 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r347290 - head/sys/dev/mlx5/mlx5_core
Message-ID:  <201905081051.x48ApToV055756@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Wed May  8 10:51:29 2019
New Revision: 347290
URL: https://svnweb.freebsd.org/changeset/base/347290

Log:
  Fix for double bus master disable in mlx5core.
  
  mlx5_pci_disable_device is calling pci_disable_device which disables
  bus master. No need to explicitly call pci_clear_master.
  
  Submitted by:	slavash@
  MFC after:	3 days
  Sponsored by:	Mellanox Technologies

Modified:
  head/sys/dev/mlx5/mlx5_core/mlx5_main.c

Modified: head/sys/dev/mlx5/mlx5_core/mlx5_main.c
==============================================================================
--- head/sys/dev/mlx5/mlx5_core/mlx5_main.c	Wed May  8 10:51:07 2019	(r347289)
+++ head/sys/dev/mlx5/mlx5_core/mlx5_main.c	Wed May  8 10:51:29 2019	(r347290)
@@ -866,7 +866,6 @@ static int mlx5_pci_init(struct mlx5_core_dev *dev, st
 	return 0;
 
 err_clr_master:
-	pci_clear_master(dev->pdev);
 	release_bar(dev->pdev);
 err_disable:
 	mlx5_pci_disable_device(dev);
@@ -877,7 +876,6 @@ err_dbg:
 static void mlx5_pci_close(struct mlx5_core_dev *dev, struct mlx5_priv *priv)
 {
 	iounmap(dev->iseg);
-	pci_clear_master(dev->pdev);
 	release_bar(dev->pdev);
 	mlx5_pci_disable_device(dev);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905081051.x48ApToV055756>