Date: Thu, 13 Sep 2001 17:44:00 -0400 (EDT) From: Mike Heffner <mheffner@vt.edu> To: Brian Poole <raj@cerias.purdue.edu> Cc: freebsd-audit@FreeBSD.ORG Subject: RE: Cleanup in adduser.perl Message-ID: <XFMail.20010913174400.mheffner@vt.edu> In-Reply-To: <20010913130145.L1855@basm.cerias.purdue.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On 13-Sep-2001 Brian Poole wrote:
| Hello,
|
| Cleaned up many similar problems in OpenBSD's adduser which was
| originally from Free, decided to mirror the changes where
| possible in FreeBSD's adduser. This patch hasn't been tested,
| but the changes are all relatively minor and should be correct.
|
| If someone could review & possibly commit, would be appreciated.
|
It looks pretty good, however I'm not too Perl knowledgeable, so I can't say
for sure. While on the subject of adduser, I've had the following similar patch
to a local admin script here for awhile. The patch adds '.' and '/' to the salt
string, and makes it match that in src/usr.bin/passwd/local_passwd.c and
crypt(3). Is there any negative effect of the following?
Index: adduser.perl
===================================================================
RCS file: /home/ncvs/src/usr.sbin/adduser/adduser.perl,v
retrieving revision 1.49
diff -u -r1.49 adduser.perl
--- adduser.perl 2001/09/06 12:21:21 1.49
+++ adduser.perl 2001/09/13 21:33:35
@@ -891,7 +891,7 @@
sub salt {
local($salt); # initialization
local($i, $rand);
- local(@itoa64) = ( '0' .. '9', 'a' .. 'z', 'A' .. 'Z' ); # 0 .. 63
+ local(@itoa64) = ( '.', '/', '0' .. '9', 'A' .. 'Z', 'a' .. 'z' ); # 0..63
warn "calculate salt\n" if $verbose > 1;
# to64
Mike
--
Mike Heffner <mheffner@[acm.]vt.edu>
Blacksburg, VA <mikeh@FreeBSD.org>
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org
iD8DBQE7oSifFokZQs3sv5kRAuqqAJ0WqQBjdYYdCRi57FbV94drziZL2gCfbTTe
880JVWfV/ZVJc5GABJJKWlI=
=Ve8u
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20010913174400.mheffner>