Date: Sat, 09 Jun 2001 00:10:29 -0700 From: Doug Barton <DougB@DougBarton.net> To: Dima Dorfman <dima@unixfreak.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern tty_snoop.c src/sys/sys snoop.h Message-ID: <3B21CBE5.F1109C14@DougBarton.net> References: <20010606224951.3CE163E0B@bazooka.unixfreak.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Dima Dorfman wrote:
>
> "David O'Brien" <obrien@Freebsd.org> writes:
> > On Tue, Jun 05, 2001 at 10:21:49AM +0300, Ruslan Ermilov wrote:
> > > > > Log:
> > > > > Style and cosmetic cleanups. This driver is now reasonably stlye(9)
> > > > > compliant. All the variable definitions and function names are
> > > > > reasonably consistent, and the functions which should be static (i.e.
> > ,
> > > > > all of them) are. Other assorted fixes were made. The majority of
> > > > > the delta is indentation fixes.
> > > >
> > > > In my ever so humble opinion it's better to do the whitespace commits
> > > > seperately. That makes it much easier to see the substantive changes.
> > > >
> > > cvs diff -w?
> >
> > Regardless, it is our practice to commit style/cosmetic changes by
> > themselves with no functionality changes mixed in (and vice-versa).
>
> Perhaps you misunderstood my commit message. There were no functional
> changes in this commit. I fixed indentation, changes a few function
> names to be consistent,
This is why I was careful to specify whitespace. Imagine this scenario.
Committer foo changes all the hotblonde variables to hotredhead to make his
new girlfriend happy, and while he's at it decides to fix indenting and
other whitespace. However, while he was being distracted by said new
girlfriend he types hotrehead one time. Now ignoring for the moment the
fact that he should have been using some variety of search/replace
functionality, the fact remains that this one tiny typo is going to be very
hard to find. Switches like -w and -bB aren't perfect, although they help.
There is no reason not to do whitespace commits seperately, and although
I'm sure YOU would never make the mistake above, it's a good habit to get
into. :)
Doug
--
If you're never wrong, you're not trying hard enough.
Do YOU Yahoo!?
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3B21CBE5.F1109C14>