Date: Fri, 24 Oct 2008 09:33:34 -0700 From: Sam Leffler <sam@freebsd.org> To: Marcel Moolenaar <xcllnt@mac.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh <imp@bsdimp.com> Subject: Re: svn commit: r184193 - in head/sys: arm/conf conf Message-ID: <4901F8DE.9050803@freebsd.org> In-Reply-To: <5D27204C-0E14-4154-BBC5-AB90B1AC657D@mac.com> References: <200810230151.m9N1ptUe044619@svn.freebsd.org> <20081023.190942.74668946.imp@bsdimp.com> <4901F173.2070701@freebsd.org> <37EC82F7-ECD8-4470-8406-084D7F839664@mac.com> <4901F46D.8010906@freebsd.org> <5D27204C-0E14-4154-BBC5-AB90B1AC657D@mac.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Marcel Moolenaar wrote:
>
> On Oct 24, 2008, at 9:14 AM, Sam Leffler wrote:
>
>>>> This is just wrong and clearly Marvel never discussed it with
>>>> anyone working on arm systems or he'd have gotten an earful.
>>>
>>> Get your facts straight.
>>>
>> I checked with folks and you never asked for review of this change.
>
> What you mean to say is: "Oops, sorry!"
So long as "you" == marcel that is correct. I don't know if it's the
phase of the moon but we seem to have a spate of commits that affect
many folks but were not peer-reviewed. This is bad for the health of
the project and I will complain when I see it happen.
>
>> As to not changing behaviour; the existing use of mbr+bsdlabels is
>> stopgap and I believe everyone actively working on these platforms
>> would like to ditch 'em.
>
> I am actively working on ARM and I need to ditch them myself.
> For that I chose to make them optional first so that people
> can keep the old behaviour if they want to. Stopgap or not,
> as ARM was before my change, those two were non-optional.
>
Glad to hear you're working on ARM. Please talk to others actively
involved so we can share the work.
Sam
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4901F8DE.9050803>