Date: Tue, 5 Oct 2021 18:31:52 +0200 From: Mathieu Arnold <mat@freebsd.org> To: Piotr Kubaj <pkubaj@anongoth.pl> Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: fb5f03a87cf4 - main - Mk/bsd.lto.mk: add global LTO support for ports Message-ID: <20211005163152.gv2vwvg4nuqwga7q@aching.in.mat.cc> In-Reply-To: <YVx84wGVlSr2nmBX@KGPE-D16> References: <202109301834.18UIYKrL013410@gitrepo.freebsd.org> <20211004133056.z7e2iyrhlwprvvvp@aching.in.mat.cc> <YVx84wGVlSr2nmBX@KGPE-D16>
next in thread | previous in thread | raw e-mail | index | archive | help
--klhpg5nv2ml5b3pw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 05, 2021 at 06:27:15PM +0200, Piotr Kubaj wrote: > On 21-10-04 15:30:56, Mathieu Arnold wrote: > > On Thu, Sep 30, 2021 at 06:34:20PM +0000, Piotr Kubaj wrote: > > > The branch main has been updated by pkubaj: > > >=20 > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3Dfb5f03a87cf432751fae= 1f0ae7f29c9d4fc65917 > > >=20 > > > commit fb5f03a87cf432751fae1f0ae7f29c9d4fc65917 > > > Author: Piotr Kubaj <pkubaj@FreeBSD.org> > > > AuthorDate: 2021-09-30 18:27:50 +0000 > > > Commit: Piotr Kubaj <pkubaj@FreeBSD.org> > > > CommitDate: 2021-09-30 18:27:50 +0000 > > >=20 > > > Mk/bsd.lto.mk: add global LTO support for ports > > > =20 > > > It's well known that LTO provides both performance and size benef= its for > > > binaries. > > > =20 > > > Add preliminary, opt-in support for global LTO enforcement to por= ts. Ports that > > > provide LTO option on their own and the ones that don't work with= LTO will need > > > to set LTO_UNSAFE in the future. > > > =20 > > > PR: 258536 > >=20 > > Not to be picky about approval and all, but this was added to the > > framework, and the framework is maintained by portmgr. When you want to > > add something to it, you must consult with portmgr before anything gets > > committed. > >=20 > > In that case, we would have told you not to do it this way, but to make > > this a Mk/Uses/lto.mk. > >=20 > > So please, turn this into a USES=3Dlto. >=20 > I did consult, but no one replied. There is absolutely no maintainer timeout for the framework, you cannot just add code there without explicit approval. > IMO adding it to USES is not a good idea, since USES are supposed to be u= sed per port and my idea was to force LTO for all ports, same way that SSP = already does. All I see in the patch is a USE_LTO knob, and a LTO_UNSAFE one, without any documentation of what it is for, what it does, what it might do, what it is about, or anything else. --=20 Mathieu Arnold --klhpg5nv2ml5b3pw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAABCgB9FiEEFD4jMKwz5Ud8Ywu3ecmT/A9inX0FAmFcffdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDE0 M0UyMzMwQUMzM0U1NDc3QzYzMEJCNzc5Qzk5M0ZDMEY2MjlEN0QACgkQecmT/A9i nX3VQAf/an04xpGttKrIOiYVWSkshIQN3sXRNFP//IYBwfjfKMmx9eP+GXNTdO0I W/k+AlhdxS6TZrHE1H1sBBNvQOJmVb+LQYAqTpeiN5CHunU/3Nxsp4pNoGO+sHJp mG+DF1lojBgCgaDFy6gOLL614jBW7UV3/KEEHw7I9Dbj5mk38O4zu/pc6sQzugUC 1h1wJGRuygAyDrHWVVCgxCGtRHYtuBuhoRfK7Hs+GfO/RlmwGQw8v0135xR+Y2Ey ny64OHuHablaYoTCA/6Rprtb8SRJYIrYl+YiOKmkQ5CY3nQsalONeWVEOZ5CAOvv PAL6C/BPb/E7KQTF4ksRXcO+w8vgIQ== =h/Va -----END PGP SIGNATURE----- --klhpg5nv2ml5b3pw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20211005163152.gv2vwvg4nuqwga7q>