Date: Wed, 12 Feb 2014 18:46:35 GMT From: Takanori Sawada <tak.swd@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/186701: order of arguments for mtx_init is incorrect Message-ID: <201402121846.s1CIkZVc007662@cgiserv.freebsd.org> Resent-Message-ID: <201402121850.s1CIo0OE021177@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 186701 >Category: kern >Synopsis: order of arguments for mtx_init is incorrect >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Feb 12 18:50:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Takanori Sawada >Release: >Organization: >Environment: FreeBSD Current >Description: Args are in wrong order to mtx_init(9) (1) http://svnweb.freebsd.org/base/head/sys/arm/broadcom/bcm2835/bcm2835_mbox.c?revision=261410&view=markup#l173 now: mtx_init(&sc->lock, "vcio mbox", MTX_DEF, 0); correct: mtx_init(&sc->lock, "vcio mbox", NULL, MTX_DEF); (2) http://svnweb.freebsd.org/base/head/sys/dev/nand/nandbus.c?revision=260180&view=markup#l177 now: mtx_init(&sc->nandbus_mtx, "nandbus lock", MTX_DEF, 0); correct: mtx_init(&sc->nandbus_mtx, "nandbus lock", NULL, MTX_DEF); (3) http://svnweb.freebsd.org/base/head/sys/powerpc/ofw/ofw_real.c?revision=253588&view=markup#l303 now: mtx_init(&of_bounce_mtx, "OF Bounce Page", MTX_DEF, 0); correct: mtx_init(&of_bounce_mtx, "OF Bounce Page", NULL, MTX_DEF); >How-To-Repeat: >Fix: >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201402121846.s1CIkZVc007662>