Date: Wed, 23 Aug 2023 12:48:08 +0530 From: Sumit Saxena <sumit.saxena@broadcom.com> To: Warner Losh <imp@bsdimp.com> Cc: Kevin Bowling <kevin.bowling@kev009.com>, Kristof Provost <kp@freebsd.org>, Warner Losh <imp@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org>, src-committers <src-committers@freebsd.org>, Chandrakanth Patil <chandrakanth.patil@broadcom.com> Subject: Re: git: 91fcacc35597 - main - if_bnxt: Add support for VLAN on Thor Message-ID: <CAL2rwxqBXqgXMdc3Wge85cE-%2BgQrK=XrZDD1p5QjAr5oeoX6GA@mail.gmail.com> In-Reply-To: <CANCZdfr6fkKPLVA2JAHiSJSsJj9-tQbFGuK%2BPj2JsEZ24qRENw@mail.gmail.com> References: <202211042255.2A4MtqVv032693@gitrepo.freebsd.org> <419530F4-DB8F-46EA-BF45-C130BCF8A3DE@FreeBSD.org> <05979953-C089-4D56-99E3-BBBF066FE277@FreeBSD.org> <CAK7dMtCJhwpV96znB4if48FtWEy091ss-nmvMp5zoLUvtkAs%2BA@mail.gmail.com> <CAK7dMtA6FL%2BCzw9Z2TC2-N0cA=WshDBsEVam0__ift9VfFrq7Q@mail.gmail.com> <CANCZdfrO7gJDsnUu465CN96V4eWowtD-eqH2340u1-Yo14F4_w@mail.gmail.com> <CANCZdfr6fkKPLVA2JAHiSJSsJj9-tQbFGuK%2BPj2JsEZ24qRENw@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] +Chandrakanth Patil Chandrakanth is working on this bug. -Sumit On Wed, Aug 23, 2023 at 6:01 AM Warner Losh <imp@bsdimp.com> wrote: > > > > On Tue, Aug 22, 2023, 6:26 PM Warner Losh <imp@bsdimp.com> wrote: >> >> >> >> On Tue, Aug 22, 2023, 5:59 PM Kevin Bowling <kevin.bowling@kev009.com> wrote: >>> >>> On Tue, Aug 22, 2023 at 3:39 PM Kevin Bowling <kevin.bowling@kev009.com> wrote: >>> > >>> > >>> > >>> > On Tue, Aug 22, 2023 at 2:07 PM Kristof Provost <kp@freebsd.org> wrote: >>> >> >>> >> On 27 Jun 2023, at 11:17, Kristof Provost wrote: >>> >> >>> >> On 4 Nov 2022, at 23:55, Warner Losh wrote: >>> >> >>> >> The branch main has been updated by imp: >>> >> >>> >> URL: https://cgit.FreeBSD.org/src/commit/?id=91fcacc355971f74aa26fc7861020dc3a2a2d717 >>> >> >>> >> commit 91fcacc355971f74aa26fc7861020dc3a2a2d717 >>> >> Author: Sumit Saxena <sumit.saxena@broadcom.com> >>> >> AuthorDate: 2022-11-04 22:24:32 +0000 >>> >> Commit: Warner Losh <imp@FreeBSD.org> >>> >> CommitDate: 2022-11-04 22:24:32 +0000 >>> >> >>> >> if_bnxt: Add support for VLAN on Thor >>> >> >>> >> Reviewed by: imp >>> >> Differential Revision: https://reviews.freebsd.org/D36443 >>> >> --- >>> >> sys/dev/bnxt/bnxt.h | 3 +- >>> >> sys/dev/bnxt/bnxt_hwrm.c | 110 ++++++++++++++++++++++++++++------------------- >>> >> sys/dev/bnxt/bnxt_hwrm.h | 7 ++- >>> >> sys/dev/bnxt/if_bnxt.c | 7 ++- >>> >> 4 files changed, 74 insertions(+), 53 deletions(-) >>> >> >>> >> This commit appears to have broken vlan on these interfaces. >>> >> My hardware is a Broadcom BCM57416 NetXtreme-E 10GBase-T Ethernet, (in a Dell T640, if that helps). >>> >> >>> >> A simple vlan creation on top of one: >>> >> ifconfig vlan create >>> >> ifconfig vlan0 vlan 201 vlandev bnxt0 >>> >> >>> >> Results in a loss of connectivity. The kernel logs this, which I assume is related: >>> >> >>> >> `bnxt0: HWRM_CFA_L2_FILTER_ALLOC command returned INVALID_PARAMS error.` >>> >> >>> >> After reverting this (and 72e9dbb58cad5262190cf2eae47f764021072128) I can create vlan interfaces on top of bnxt0 without losing connectivity. >>> >> >>> >> >>> >> Should we revert this before 14.0? >>> >> >>> >> There’s also a report of what I think is the same issue in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269133 >>> >> >>> >> There’s a proposed patch there, but it did not work for me. >>> > >>> > >>> > In markj’s analysis he mentions the issue of the reinit. >>> > >>> > It sounds like there are multiple bugs in this driver but one quick band aid may be to mark the driver as not needing re-init for VLAN modifications.. that sounds unlikely and was probably an accident when the if reset functionality was added. You can check e1000 for that. >>> >>> Here's what I mean as a patch https://reviews.freebsd.org/D41558 >>> >>> > Note I don’t have this hw and haven’t audited the code so this could be noise but it’s an easy thing to check. >> >> >> Is there a good bug we can post that link to for someone to test? > > > Duh.. posted to bug above and > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222680 > > Warner > >> >> Warner >>> >>> > >>> >> Best regards, >>> >> Kristof [-- Attachment #2 --] 0m *H ^0Z10 `He 0 *H 0 0xJ?u4 0 *H 0L1 0 U GlobalSign Root CA - R310U GlobalSign10U GlobalSign0 200916000000Z 280916000000Z0[1 0 UBE10U GlobalSign nv-sa110/U(GlobalSign GCC R3 PersonalSign 2 CA 20200"0 *H 0 \',mH@q |XKMg)# \=TҨjB:-UH}7nTi* ^s[@Ϯ2u {{3pד j*h_[6>۴ְ铋^GYC)0g(1@ +le5{ iZ52J FC| ؗcHSg ==%.> 0 u鷶pt`ҚK<P4\r"6aN3 00U 0`U %Y0W++ +7 +7 +7 +7 ++0U 0 0 U 3X[4uVdվHޡ0 U #0K.E$MPc0z+n0l0-+0!http://ocsp.globalsign.com/rootr30;+0/http://secure.globalsign.com/cacert/root-r3.crt06U /0-0+)'%http://crl.globalsign.com/root-r3.crl0ZU S0Q0 +2(0B +2( 0402+&https://www.globalsign.com/repository/0 *H tp wK?98bE"ڡ:ߌNEu#T_[; .k܊0lվ-Bo+ljT[EsOdb&_ HY;^ )d7^Dx N3Oq E*X7=j/P K0=4)jZ2 l"l#c -YTG> ݂H[30_0G !XS0 *H 0L1 0 U GlobalSign Root CA - R310U GlobalSign10U GlobalSign0 090318100000Z 290318100000Z0L1 0 U GlobalSign Root CA - R310U GlobalSign10U GlobalSign0"0 *H 0 %vyx"(vŭrFCDz_$.K`FR Gpld,= +y;wIjb/ ^h߉'8>&Y sް&[`I(i;(坊aW7tt:r/.л= 3+S:sA :O.2`W˹hh8&`uw I@H1a^wdz_b lTin郓qvi B0@0U 0U 00 U K.E$MPc0 *H K@P TEI A(3kt - sgJD{xnlo)39EÎWlS-$lcShgV>5!hS̐]FzX(/ 7ADmS(~g L'Lssv z- ,<U~6WI.-|`AQ#2k,3 :;%҆@;,xa/Uo߄ M(rbPe 뒗1ٳGX?_0L04 ,h40 *H 0[1 0 UBE10U GlobalSign nv-sa110/U(GlobalSign GCC R3 PersonalSign 2 CA 20200 220910091535Z 250910091535Z01 0 UIN10U Karnataka10U Bangalore10U Broadcom Inc.10U Sumit Saxena1(0& *H sumit.saxena@broadcom.com0"0 *H 0 <Y1NâӣнeMdH BF60HXw8 9 @g /`'F̑:4)y|361b|Q 'swd|ILET.-Ճ!^ZUe |{a*_! AaһxA ɍVԟ1oV²ZSmޅ/"|qj`ث578ƚ=_g7+dvVh_r!ſm\ 00U 0+00N+0Bhttp://secure.globalsign.com/cacert/gsgccr3personalsign2ca2020.crt0A+05http://ocsp.globalsign.com/gsgccr3personalsign2ca20200MU F0D0B +2( 0402+&https://www.globalsign.com/repository/0 U 0 0IU B0@0><:8http://crl.globalsign.com/gsgccr3personalsign2ca2020.crl0$U 0sumit.saxena@broadcom.com0U % 0 +0 U #03X[4uVdվHޡ0 U LHCjm{x\0 *H \zq\SdXHsG(>e\S k 2$~1W_(0wթG _r˓&Ld7lgE_<z"D|}kQ Y99uDlC^gL %ojZ['+` % 21CP,gVrd1X'" &mqi3FhC<1m0i0k0[1 0 UBE10U GlobalSign nv-sa110/U(GlobalSign GCC R3 PersonalSign 2 CA 2020 ,h40 `He 0/ *H 1" `'f8 6C9_B & \/E0 *H 1 *H 0 *H 1 230823071836Z0i *H 1\0Z0 `He*0 `He0 `He0 *H 0 *H 0 *H 0 `He0 *H 0'# ۏ ]s NATyD5vʀ]q֗B:.J;Ϋ!*Q<'e_j km6/5BOA.St^eL l)ir_.VF[4Iޕ Q ~FIhLK2#١cdY a Dhm:ԊnZGˑ8< v)oS73'}TZH<T̠R`ec', 'Q09\oVhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAL2rwxqBXqgXMdc3Wge85cE-%2BgQrK=XrZDD1p5QjAr5oeoX6GA>