Date: Fri, 2 Mar 2018 02:39:41 +0000 (UTC) From: Kyle Evans <kevans@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r330262 - head/stand/lua Message-ID: <201803020239.w222dfHK062931@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: kevans Date: Fri Mar 2 02:39:41 2018 New Revision: 330262 URL: https://svnweb.freebsd.org/changeset/base/330262 Log: lualoader: Use #str instead of tracking length with 'n' We really gain almost nothing by tracking length separately, especially when it's as easy as "#str", so reduce complexity. Modified: head/stand/lua/password.lua Modified: head/stand/lua/password.lua ============================================================================== --- head/stand/lua/password.lua Fri Mar 2 02:39:16 2018 (r330261) +++ head/stand/lua/password.lua Fri Mar 2 02:39:41 2018 (r330262) @@ -42,7 +42,6 @@ local twiddle_chars = {"/", "-", "\\", "|"} -- Module exports function password.read(prompt_length) local str = "" - local n = 0 local twiddle_pos = 1 local function draw_twiddle() @@ -60,14 +59,13 @@ function password.read(prompt_length) break end if ch == core.KEY_BACKSPACE or ch == core.KEY_DELETE then - if n > 0 then - n = n - 1 + if #str > 0 then if show_password_mask then loader.printc("\008 \008") else draw_twiddle() end - str = str:sub(1, n) + str = str:sub(1, #str - 1) end else if show_password_mask then @@ -76,7 +74,6 @@ function password.read(prompt_length) draw_twiddle() end str = str .. string.char(ch) - n = n + 1 end end return str
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201803020239.w222dfHK062931>