Date: Fri, 13 Mar 2015 17:04:32 -0400 From: John Baldwin <jhb@freebsd.org> To: Alexander Motin <mav@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r279965 - head/usr.sbin/bhyve Message-ID: <2486513.R1ROTfJbIk@ralph.baldwin.cx> In-Reply-To: <201503132014.t2DKEZY3084111@svn.freebsd.org> References: <201503132014.t2DKEZY3084111@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, March 13, 2015 08:14:35 PM Alexander Motin wrote: > Author: mav > Date: Fri Mar 13 20:14:35 2015 > New Revision: 279965 > URL: https://svnweb.freebsd.org/changeset/base/279965 > > Log: > Polish AHCI disk identify data and fix speed negotiation. > > MFC after: 2 weeks > > Modified: > head/usr.sbin/bhyve/ahci.h > head/usr.sbin/bhyve/pci_ahci.c > > Modified: head/usr.sbin/bhyve/ahci.h > ============================================================================== > --- head/usr.sbin/bhyve/ahci.h Fri Mar 13 20:10:09 2015 (r279964) > +++ head/usr.sbin/bhyve/ahci.h Fri Mar 13 20:14:35 2015 (r279965) > @@ -96,13 +96,14 @@ > #define ATA_SS_SPD_NO_SPEED 0x00000000 > #define ATA_SS_SPD_GEN1 0x00000010 > #define ATA_SS_SPD_GEN2 0x00000020 > -#define ATA_SS_SPD_GEN3 0x00000040 > +#define ATA_SS_SPD_GEN3 0x00000030 > > #define ATA_SS_IPM_MASK 0x00000f00 > #define ATA_SS_IPM_NO_DEVICE 0x00000000 > #define ATA_SS_IPM_ACTIVE 0x00000100 > #define ATA_SS_IPM_PARTIAL 0x00000200 > #define ATA_SS_IPM_SLUMBER 0x00000600 > +#define ATA_SS_IPM_DEVSLEEP 0x00000800 I wonder if it would make sense to have a shared header for these constants (given that it seems they are copied in 4 other places for in-kernel drivers)? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2486513.R1ROTfJbIk>