Date: Wed, 13 Feb 2019 15:11:19 +0000 From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 235701] security/py-certbot: Add man page Message-ID: <bug-235701-21822-IM2pmHtLOG@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-235701-21822@https.bugs.freebsd.org/bugzilla/> References: <bug-235701-21822@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D235701 --- Comment #8 from Tobias Kortkamp <tobik@freebsd.org> --- Comment on attachment 201984 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D201984 svn-diff-alternate 1. MAN should be named MANPAGES as it usually is. 2. The new options and helpers are badly ordered [1]. 3. Remove .include <bsd.port.options.mk> again and use options helpers targets. 4. This should probably be post-build-MAN-on (or post-build-MANPAGES-on aft= er fixing the option name): +pre-install: 5. gmake is not declared as a build dependency, so this will probably fail: + ${LOCALBASE}/bin/gmake -C ${WRKSRC}/docs man 6. Use the INSTALL_MAN macro to install files into STAGEDIR, not CP. [2] 7. What does this do and why does it require gsed? + ${SED_CMD} -i '1i\.if n .pl 2000v' ${STAGEDIR}${PREFIX}/man/man7/certbot.7 If the input for creating certbot.7 is already broken can it not be fixed instead? 8. Why is patch-docs_conf.py needed? [1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html [2] https://www.freebsd.org/doc/en/books/porters-handbook/install.html --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-235701-21822-IM2pmHtLOG>