Date: Wed, 14 Jan 2015 05:25:54 +0300 From: rozhuk.im@gmail.com To: "'Eric van Gyzen'" <eric@vangyzen.net>, "'Lars Engels'" <lars.engels@0x20.net>, "'Allan Jude'" <allanjude@freebsd.org> Cc: freebsd-hackers@freebsd.org Subject: RE: [PATCH] Display progress during getmemsize() so the kernel doesn't look like it hanged Message-ID: <54b5d3b4.2aa3700a.3a6c.25f4@mx.google.com> In-Reply-To: <54B53E40.1030903@vangyzen.net> References: <D0D89A8E.129518%rpokala@panasas.com> <54B35B36.4040504@freebsd.org> <20150113091122.GK67556@e-new.0x20.net> <54B53E40.1030903@vangyzen.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> >> Is this feature still useful with memtest.tests=0? > > This feature is useful for everyone who has it set to 1, if they know > > about it or not. So it's a very useful feature. > > Agreed. > > Comments on the patch: > > The patch will divide by zero when PAGE_SIZE > 1 MiB. Maybe remove > PAGES_PER_MB, and just use PAGES_PER_GB. Make it const, too. > > The "total" line is mostly redundant with the later messages regarding > "real memory" and "avail memory". I suggest removing it. > Maybe just write: checked XX megabytes of memory?
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54b5d3b4.2aa3700a.3a6c.25f4>