Date: Mon, 6 Nov 2006 00:15:45 +0000 (UTC) From: "Christian S.J. Peron" <csjp@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/security/audit audit_arg.c audit_private.h Message-ID: <200611060015.kA60Fj8v021054@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
csjp 2006-11-06 00:15:45 UTC
FreeBSD src repository
Modified files:
sys/security/audit audit_arg.c audit_private.h
Log:
Change the type of ar_arg_sockaddr from struct sockaddr to struct
sockaddr_storage. This structure is defined in RFC 2553 and is a more
semantically correct structure for holding IP and IP6 sockaddr information.
struct sockaddr is not big enough to hold all the required information for
IP6, resulting in truncated addresses et al when auditing IP6 sockaddr
information.
We also need to assume that the sa->sa_len has been validated before the call to
audit_arg_sockaddr() is made, otherwise it could result in a buffer overflow.
This is being done to accommodate auditing of network related arguments (like
connect, bind et al) that will be added soon.
Discussed with: rwatson
Obtained from: TrustedBSD Project
MFC after: 2 weeks
Revision Changes Path
1.7 +1 -2 src/sys/security/audit/audit_arg.c
1.12 +1 -1 src/sys/security/audit/audit_private.h
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611060015.kA60Fj8v021054>