Date: Mon, 22 Jun 2009 10:23:54 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/netatalk COPYRIGHT aarp.c at_control.c at_var.h ddp_input.c ddp_output.c ddp_pcb.c Message-ID: <200906221024.n5MAOAB4082418@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rwatson 2009-06-22 10:23:54 UTC FreeBSD src repository Modified files: sys/netatalk COPYRIGHT aarp.c at_control.c at_var.h ddp_input.c ddp_output.c ddp_pcb.c Log: SVN rev 194619 on 2009-06-22 10:23:54Z by rwatson Add a global rwlock, at_ifaddr_rw, to protect the global netatalk address lists, at_ifaddr_list. Acquire the lock, and use ifaddr refcounts where necessary, to close most known address-related races in netatalk. Annotate one potential race in at_control() where we acquire an ifaddr reference, drop the global lock, and scrub the address from the ifnet before re-acquiring the global lock, which could allow for a writer-writer race. MFC after: 3 weeks Revision Changes Path 1.5 +1 -1 src/sys/netatalk/COPYRIGHT 1.48 +34 -4 src/sys/netatalk/aarp.c 1.49 +53 -47 src/sys/netatalk/at_control.c 1.16 +8 -0 src/sys/netatalk/at_var.h 1.36 +25 -21 src/sys/netatalk/ddp_input.c 1.35 +9 -1 src/sys/netatalk/ddp_output.c 1.54 +13 -2 src/sys/netatalk/ddp_pcb.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200906221024.n5MAOAB4082418>