Date: Sun, 05 Oct 1997 13:49:39 -0700 From: Julian Elischer <julian@whistle.com> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Joerg Wunsch <joerg_wunsch@uriah.heep.sax.de>, freebsd-scsi@FreeBSD.ORG, David Greenman <davidg@FreeBSD.ORG> Subject: Re: New SCSI Framework Patches Available Message-ID: <3437FD62.7D55368C@whistle.com> References: <8140.876053997@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp wrote: my new disk layer stuff basically works in byte offsets. it starts with b_blkno, but all comparisins etc. end up being u_int64_t based.. (offset_t?) I'd rather see byte offsets ASAP, so that it matches the resid and other count values. of course it makes it easier to accidentally try do non-alligned transfers, but if you are making that big a, then othingis likely to help you except having your code rejected too much. > > >> > I would prefer a transition from b_blkno to b_offset, thereby > >> > eliminating all the ``shift right here, shift back left there'' mess > >> > completely. > > I agree. me too though I'd like to leave the b_pblkno, or maybe make it a b_poffset. > > -- > Poul-Henning Kamp FreeBSD coreteam member > phk@FreeBSD.ORG "Real hackers run -current on their laptop."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3437FD62.7D55368C>