Date: Fri, 7 Sep 2012 15:37:15 GMT From: yamayan <yamayan@kbh.biglobe.ne.jp> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/171414: [patch] compile error at dbus header in c++11 mode Message-ID: <201209071537.q87FbFjF048462@red.freebsd.org> Resent-Message-ID: <201209071540.q87Fe3AW091823@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 171414
>Category: misc
>Synopsis: [patch] compile error at dbus header in c++11 mode
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Sep 07 15:40:03 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: yamayan
>Release: 10-CURRENT
>Organization:
>Environment:
FreeBSD genius 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r240071M: Mon Sep 3 23:05:03 JST 2012 root@genius:/usr/obj/usr/src/sys/NYANCO amd64
>Description:
No space between literal and identifier in dbus header.
related ports/171343
www/firefox build error message:
(snip)
In file included from /usr/ports/www/firefox/work/mozilla-release/hal/linux/UPowerClient.cpp:8:
In file included from /usr/local/include/dbus-1.0/dbus/dbus-glib-lowlevel.h:28:
In file included from /usr/local/include/dbus-1.0/dbus/dbus.h:30:
In file included from /usr/local/include/dbus-1.0/dbus/dbus-address.h:31:
In file included from /usr/local/include/dbus-1.0/dbus/dbus-errors.h:33:
/usr/local/include/dbus-1.0/dbus/dbus-protocol.h:459:77: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
#define DBUS_INTROSPECT_1_0_XML_DOCTYPE_DECL_NODE "<!DOCTYPE node PUBLIC \""DBUS_INTROSPECT_1_0_XML_PUBLIC_IDENTIFIER"\"\n\""DBUS_INTROSPECT_1_0_XML_SYSTEM_IDENTIFIER"\">\n"
^
/usr/local/include/dbus-1.0/dbus/dbus-protocol.h:459:126: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
#define DBUS_INTROSPECT_1_0_XML_DOCTYPE_DECL_NODE "<!DOCTYPE node PUBLIC \""DBUS_INTROSPECT_1_0_XML_PUBLIC_IDENTIFIER"\"\n\""DBUS_INTROSPECT_1_0_XML_SYSTEM_IDENTIFIER"\">\n"
^
(snip)
>How-To-Repeat:
>Fix:
add spaces between literal and identifier.
Patch attached with submission follows:
--- dbus/dbus-protocol.h.orig 2012-05-05 17:04:15.735156255 +0900
+++ dbus/dbus-protocol.h 2012-05-05 17:04:50.264154284 +0900
@@ -456,7 +456,7 @@
/** XML system identifier of the introspection format version 1.0 */
#define DBUS_INTROSPECT_1_0_XML_SYSTEM_IDENTIFIER "http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd"
/** XML document type declaration of the introspection format version 1.0 */
-#define DBUS_INTROSPECT_1_0_XML_DOCTYPE_DECL_NODE "<!DOCTYPE node PUBLIC \""DBUS_INTROSPECT_1_0_XML_PUBLIC_IDENTIFIER"\"\n\""DBUS_INTROSPECT_1_0_XML_SYSTEM_IDENTIFIER"\">\n"
+#define DBUS_INTROSPECT_1_0_XML_DOCTYPE_DECL_NODE "<!DOCTYPE node PUBLIC \"" DBUS_INTROSPECT_1_0_XML_PUBLIC_IDENTIFIER "\"\n\"" DBUS_INTROSPECT_1_0_XML_SYSTEM_IDENTIFIER "\">\n"
/** @} */
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201209071537.q87FbFjF048462>