Date: Wed, 14 Mar 2018 17:20:00 -0600 From: Alan Somers <asomers@freebsd.org> To: Shawn Webb <shawn.webb@hardenedbsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329984 - in head: cddl/contrib/opensolaris/lib/libzpool/common sys/cddl/compat/opensolaris/sys Message-ID: <CAOtMX2ggxhLFmV=Dz7b5BCoriR_C0NcnYJra17ubEy-dptymyA@mail.gmail.com> In-Reply-To: <20180314231150.whi6ndflt77iyybw@mutt-hbsd> References: <201802251429.w1PEThjY035303@repo.freebsd.org> <20180314225009.gu3awgryggsxqmff@mutt-hbsd> <CAOtMX2g=aXd0gtHOoN2NiNv1ECG-mrZHR8KWrihzk6mEL14B%2Bg@mail.gmail.com> <20180314225623.zp6ufw5h7bua4etf@mutt-hbsd> <CAOtMX2ghziwT49xqe5pHaPb0p6ceG5BuYnOgCdRrDCv-_7ZgOg@mail.gmail.com> <20180314231150.whi6ndflt77iyybw@mutt-hbsd>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Mar 14, 2018 at 5:11 PM, Shawn Webb <shawn.webb@hardenedbsd.org> wrote: > On Wed, Mar 14, 2018 at 05:06:09PM -0600, Alan Somers wrote: > > On Wed, Mar 14, 2018 at 4:56 PM, Shawn Webb <shawn.webb@hardenedbsd.org> > > wrote: > > > > > On Wed, Mar 14, 2018 at 04:51:27PM -0600, Alan Somers wrote: > > > > On Wed, Mar 14, 2018 at 4:50 PM, Shawn Webb < > shawn.webb@hardenedbsd.org> > > > > wrote: > > > > > > > > > On Sun, Feb 25, 2018 at 02:29:43PM +0000, Alan Somers wrote: > > > > > > Author: asomers > > > > > > Date: Sun Feb 25 14:29:43 2018 > > > > > > New Revision: 329984 > > > > > > URL: https://svnweb.freebsd.org/changeset/base/329984 > > > > > > > > > > > > Log: > > > > > > Don't declare __assfail as static > > > > > > > > > > > > It gets called by dmu_buf_init_user, which is inline but not > > > static. > > > > > So it > > > > > > needs global linkage itself. > > > > > > > > > > > > Reported by: GCC-6 > > > > > > MFC after: 17 days > > > > > > X-MFC-With: 329722 > > > > > > > > > > > > > > > > Hey Alan, > > > > > > > > > > This commit breaks compiling world with ASAN. > > > > > > > > > > Some applications, like zfs, will fail with this error: > > > > > > > > > > /lib/libuutil.so.2: Undefined symbol "__assfail" > > > > > > > > > > Thanks, > > > > > > > > > > > > > How does one build world with ASAN ? > > > > > > HardenedBSD has a feature branch in its playground repo for ASAN-ified > > > world. > > > > > > We introduced two new MK_* toggles: MK_ASAN and MK_ASAN_RECOVER. > > > MK_ASAN is self-explanitory. MK_ASAN_RECOVER tells the sanitizer > > > framework to let the application continue running instead of abort > > > execution. > > > > > > Here's where the magic gets set: > > > > > > https://github.com/HardenedBSD/hardenedBSD-playground/blob/hardened/ > > > current/asan/share/mk/bsd.prog.mk#L125-L134 > > > > > > Thanks, > > > > > > > I don't use HardenedBSD. Can you provide an invocation that will > > demonstrate the breakage on FreeBSD head? I tried a few things, and they > > all either worked, or failed with errors other than the one you showed. > > No worries. I've just reverted the commit in that feature branch. If I > have time, I'll see about porting the ASAN work to vanilla FreeBSD. > But my time is extremely limited these days. > > Thanks, > Ok. BTW, that commit is due for MFC as of today. Unless I hear from you otherwise, I'll go ahead and MFC it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2ggxhLFmV=Dz7b5BCoriR_C0NcnYJra17ubEy-dptymyA>