Date: Mon, 8 Feb 2016 03:47:57 +1100 (EST) From: Bruce Evans <brde@optusnet.com.au> To: Pedro Giffuni <pfg@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r295362 - head/sys/fs/cd9660 Message-ID: <20160208034651.X3197@besplex.bde.org> In-Reply-To: <56B76ABA.8000607@FreeBSD.org> References: <201602070348.u173meT4000314@repo.freebsd.org> <20160207175356.A867@besplex.bde.org> <56B76ABA.8000607@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 7 Feb 2016, Pedro Giffuni wrote: > On 02/07/16 02:13, Bruce Evans wrote: >> On Sun, 7 Feb 2016, Pedro F. Giffuni wrote: >> >>> Log: >>> cd9660: Drop an unnecessary check for NULL. >>> >>> This was unnecessary and also confused Coverity. >>> >>> Confirmed on: NetBSD >>> CID: 978558 >> >> This leaves many similar bugs unfixed nearby. One is a null pointer >> panic, not just an unnecessary check. > > I admittedly oversimplified the commit log here. > > Not only the value can't be null, our brelse() also ignores NULL values. > > From sys/kern/vfs_bio.c: > ____ > /* > * Many function erroneously call brelse with a NULL bp under rare > * error conditions. Simply return when called with a NULL bp. > */ > if (bp == NULL) > return; > ... > ____ It has only done that for 11 days. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160208034651.X3197>